Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deps]: minification in DS #14961

Merged
merged 2 commits into from Nov 22, 2022
Merged

[deps]: minification in DS #14961

merged 2 commits into from Nov 22, 2022

Conversation

joshuaellis
Copy link
Member

@joshuaellis joshuaellis commented Nov 22, 2022

What does it do?

  • Use's alpha version of DS thats transpiled to 2015 (previously was 2020)

Why is it needed?

  • For some reason when the target of ESBuildMinifyPlugin is set lower than es2018 the application breaks when the DS is transpiled to es2020

@alexandrebodin can we release an experimental version to check this fixes our issue?

If the fix is validated I can release stable version of the DS that we can then merge?

@joshuaellis joshuaellis added source: dependencies Source is dependency problem pr: fix This PR is fixing a bug labels Nov 22, 2022
@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Base: 59.57% // Head: 59.57% // No change to project coverage 👍

Coverage data is based on head (e4dd1b2) compared to base (693f873).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14961   +/-   ##
=======================================
  Coverage   59.57%   59.57%           
=======================================
  Files        1339     1339           
  Lines       32605    32605           
  Branches     6215     6215           
=======================================
  Hits        19424    19424           
  Misses      11317    11317           
  Partials     1864     1864           
Flag Coverage Δ
back 49.70% <ø> (ø)
front 64.07% <ø> (ø)
unit_back 49.70% <ø> (ø)
unit_front 64.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

alexandrebodin
alexandrebodin previously approved these changes Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix This PR is fixing a bug source: dependencies Source is dependency problem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants