[features][ML listview] Sort on table headers #14963
Merged
+93
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trapi/strapi into ML-listview/sort
Codecov ReportBase: 49.78% // Head: 59.77% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## features/MediaLibrary-listview #14963 +/- ##
==================================================================
+ Coverage 49.78% 59.77% +9.98%
==================================================================
Files 290 1343 +1053
Lines 10189 32712 +22523
Branches 2254 6239 +3985
==================================================================
+ Hits 5073 19554 +14481
- Misses 4217 11298 +7081
- Partials 899 1860 +961
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jhoward1994
reviewed
Nov 22, 2022
jhoward1994
requested changes
Nov 22, 2022
joshuaellis
requested changes
Nov 23, 2022
| <IconButton | ||
| label={sortLabel} | ||
| onClick={() => handleClickSort(isSorted, name)} | ||
| icon={isUp ? <CarretUp /> : <CarretDown />} |
There was a problem hiding this comment.
Worth passing a children instead? wdyt?
There was a problem hiding this comment.
why not yes! just out of curiosity, is there a noticeable difference between passing it as prop/children? for better reading?
joshuaellis
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Make
name,createdAtandupdatedAtcolumns sortableTests
Sort on any of those attributes
Should be accessible through keyboard + voice reader tools