Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve marketplace tests performance #15006

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

remidej
Copy link
Contributor

@remidej remidej commented Nov 25, 2022

What does it do?

This is a followup to #14935 to apply the feedback from @madhurisandbhor

It improves performance by using getByTestId instead of getByRole wherever possible.

Before After
index.test.js 5.4s 5.4s
providers.test.js 34.9 30.5s
plugins.test.js 66.2s 58.1s
Total 66.8s 59.4s

@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Base: 49.80% // Head: 59.79% // Increases project coverage by +9.99% 🎉

Coverage data is based on head (a63ee30) compared to base (d8cecee).
Patch coverage: 97.50% of modified lines in pull request are covered.

Additional details and impacted files
@@                      Coverage Diff                      @@
##           feature/market-pagination   #15006      +/-   ##
=============================================================
+ Coverage                      49.80%   59.79%   +9.99%     
=============================================================
  Files                            290     1340    +1050     
  Lines                          10184    32689   +22505     
  Branches                        2252     6186    +3934     
=============================================================
+ Hits                            5072    19546   +14474     
- Misses                          4214    11296    +7082     
- Partials                         898     1847     +949     
Flag Coverage Δ
front 64.31% <97.50%> (?)
unit 49.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...n/src/pages/MarketplacePage/tests/mocks/plugins.js 100.00% <ø> (ø)
...src/pages/MarketplacePage/tests/mocks/providers.js 100.00% <ø> (ø)
...ore/admin/admin/src/pages/MarketplacePage/index.js 95.14% <91.66%> (ø)
.../src/hooks/useFetchMarketplacePlugins/utils/api.js 100.00% <100.00%> (ø)
...rc/hooks/useFetchMarketplaceProviders/utils/api.js 100.00% <100.00%> (ø)
...lacePage/components/NpmPackagesPagination/index.js 100.00% <100.00%> (ø)
...in/admin/src/pages/MarketplacePage/tests/server.js 94.59% <100.00%> (ø)
...n/admin/src/content-manager/pages/App/useModels.js 0.00% <0.00%> (ø)
...ers-permissions/admin/src/pages/Providers/index.js 69.89% <0.00%> (ø)
...c/content-manager/components/Inputs/utils/index.js 100.00% <0.00%> (ø)
... and 1046 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@madhurisandbhor madhurisandbhor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@remidej remidej merged commit 380ee73 into feature/market-pagination Nov 28, 2022
@remidej remidej deleted the market-pagination/tests-perf branch November 28, 2022 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants