Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[design-system]: update to 1.4.0 #15026

Merged
merged 3 commits into from Nov 30, 2022
Merged

[design-system]: update to 1.4.0 #15026

merged 3 commits into from Nov 30, 2022

Conversation

simotae14
Copy link
Contributor

What does it do?

  • Updates the design-system dependencies
  • Updates snapshots

Why is it needed?

We need it to use the new version of the Design System

@simotae14 simotae14 added source: dependencies Source is dependency problem pr: chore This PR contains chore tasks (cleanups, configs, tooling...) labels Nov 28, 2022
@simotae14 simotae14 added this to the 4.5.3 milestone Nov 28, 2022
@simotae14 simotae14 self-assigned this Nov 28, 2022
@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Base: 49.90% // Head: 59.79% // Increases project coverage by +9.88% 🎉

Coverage data is based on head (a39b999) compared to base (3ebd2db).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15026      +/-   ##
==========================================
+ Coverage   49.90%   59.79%   +9.88%     
==========================================
  Files         290     1345    +1055     
  Lines       10236    32682   +22446     
  Branches     2267     6234    +3967     
==========================================
+ Hits         5108    19541   +14433     
- Misses       4228    11281    +7053     
- Partials      900     1860     +960     
Flag Coverage Δ
back 49.90% <ø> (ø)
front 64.30% <ø> (?)
unit_back 49.90% <ø> (ø)
unit_front 64.30% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../components/FolderCard/FolderCardCheckbox/index.js 100.00% <0.00%> (ø)
...n/admin/src/components/PluginsInitializer/index.js 60.00% <0.00%> (ø)
packages/plugins/i18n/admin/src/index.js 0.00% <0.00%> (ø)
...onents/DataManagerProvider/utils/validateSchema.js 0.00% <0.00%> (ø)
...ent-type-builder/admin/src/hooks/useDataManager.js 0.00% <0.00%> (ø)
...es/core/admin/admin/src/utils/checkFormValidity.js 42.85% <0.00%> (ø)
...ges/SettingsPage/pages/Users/EditPage/utils/api.js 0.00% <0.00%> (ø)
...s/admin/src/pages/AdvancedSettings/utils/schema.js 100.00% <0.00%> (ø)
...manager/components/DynamicComponentCard/Wrapper.js 0.00% <0.00%> (ø)
...ontentTypeCollapse/CollapsePropertyMatrix/index.js 52.38% <0.00%> (ø)
... and 1045 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@Bassel17 Bassel17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@christiancp100 christiancp100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simotae14 simotae14 merged commit fb4f335 into main Nov 30, 2022
@simotae14 simotae14 deleted the chore/ds-140 branch November 30, 2022 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: dependencies Source is dependency problem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants