Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[features][authLogo] Update tracking events #15125

Merged
merged 1 commit into from
Dec 9, 2022

Conversation

ronronscelestes
Copy link
Contributor

@ronronscelestes ronronscelestes commented Dec 8, 2022

What

Update trackUsage events with a payload to reflect which logo was reset or changed
See CONTENT-778

@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Base: 59.85% // Head: 59.85% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (66691f5) compared to base (bda682d).
Patch coverage: 33.33% of modified lines in pull request are covered.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           features/authLogo   #15125      +/-   ##
=====================================================
- Coverage              59.85%   59.85%   -0.01%     
=====================================================
  Files                   1345     1345              
  Lines                  32753    32756       +3     
  Branches                6252     6253       +1     
=====================================================
+ Hits                   19604    19605       +1     
- Misses                 11288    11290       +2     
  Partials                1861     1861              
Flag Coverage Δ
back 49.90% <ø> (ø)
front 64.37% <33.33%> (-0.01%) ⬇️
unit_back 49.90% <ø> (ø)
unit_front 64.37% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ages/ApplicationInfosPage/components/Form/index.js 82.35% <0.00%> (-2.50%) ⬇️
...s/SettingsPage/pages/ApplicationInfosPage/index.js 90.47% <50.00%> (-1.33%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ronronscelestes ronronscelestes marked this pull request as ready for review December 9, 2022 08:41
@ronronscelestes ronronscelestes merged commit 2b6b92b into features/authLogo Dec 9, 2022
@ronronscelestes ronronscelestes deleted the authLogo/tracker-update branch December 9, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants