New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Relations are missing a focus outline on a single item title #15164
fix: Relations are missing a focus outline on a single item title #15164
Conversation
Codecov ReportBase: 59.87% // Head: 59.90% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #15164 +/- ##
==========================================
+ Coverage 59.87% 59.90% +0.02%
==========================================
Files 1348 1348
Lines 32810 32811 +1
Branches 6260 6260
==========================================
+ Hits 19646 19654 +8
+ Misses 11308 11302 -6
+ Partials 1856 1855 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
packages/core/admin/admin/src/content-manager/components/RelationInput/RelationInput.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @gitstart
just a small proposition :)
packages/core/admin/admin/src/content-manager/components/RelationInput/RelationInput.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @gitstart 😊
The tests are not launching weirdly, could you try to update your branch with main
to see if it fixes it? 👀
This PR was pushed through Gitstart, with contributions from @raph941, @phunguyenmurcul. |
What does it do?
Adds outline on a single item title once focused
Why is it needed?
BoxEllipsis
causesLinkEllipsis
:focus-visible:after
"outline" to be hidden, resulting in focus outline position being lost when focused on the item link title.How to test it?
Related issue(s)/PR(s)
Fixes #15108
Demo
Screen.Recording.2022-12-12.at.5.13.08.PM.mov