Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Relations are missing a focus outline on a single item title #15164

Merged
merged 5 commits into from Dec 14, 2022
Merged

fix: Relations are missing a focus outline on a single item title #15164

merged 5 commits into from Dec 14, 2022

Conversation

gitstart
Copy link
Contributor

@gitstart gitstart commented Dec 13, 2022

What does it do?

Adds outline on a single item title once focused

Why is it needed?

BoxEllipsis causes LinkEllipsis :focus-visible:after "outline" to be hidden, resulting in focus outline position being lost when focused on the item link title.

How to test it?

  • Create a content-type with a related field.
  • Add at least one relation.
  • Tab through the relation item(s).
  • Notice that the item name is outlined once focused.

Related issue(s)/PR(s)

Fixes #15108

Demo

Screen.Recording.2022-12-12.at.5.13.08.PM.mov

@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Base: 59.87% // Head: 59.90% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (8de62f9) compared to base (a497626).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15164      +/-   ##
==========================================
+ Coverage   59.87%   59.90%   +0.02%     
==========================================
  Files        1348     1348              
  Lines       32810    32811       +1     
  Branches     6260     6260              
==========================================
+ Hits        19646    19654       +8     
+ Misses      11308    11302       -6     
+ Partials     1856     1855       -1     
Flag Coverage Δ
back 50.07% <ø> (ø)
front 64.36% <50.00%> (+0.03%) ⬆️
unit_back 50.07% <ø> (ø)
unit_front 64.36% <50.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-manager/components/RelationInput/RelationInput.js 90.90% <ø> (-0.06%) ⬇️
packages/core/admin/admin/src/pages/App/index.js 66.66% <50.00%> (-0.65%) ⬇️
...core/admin/admin/src/hooks/useFetchClient/index.js 100.00% <0.00%> (+66.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gitstart gitstart marked this pull request as ready for review December 13, 2022 09:19
Copy link
Contributor

@ronronscelestes ronronscelestes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @gitstart
just a small proposition :)

@ronronscelestes ronronscelestes added source: core:content-manager Source is core/content-manager package pr: fix This PR is fixing a bug labels Dec 14, 2022
Copy link
Contributor

@ronronscelestes ronronscelestes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @gitstart 😊
The tests are not launching weirdly, could you try to update your branch with main to see if it fixes it? 👀

@ronronscelestes ronronscelestes added this to the 4.5.4 milestone Dec 14, 2022
@ronronscelestes ronronscelestes merged commit af0cd00 into strapi:main Dec 14, 2022
@gitstart
Copy link
Contributor Author

This PR was pushed through Gitstart, with contributions from @raph941, @phunguyenmurcul.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix This PR is fixing a bug source: core:content-manager Source is core/content-manager package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relations are missing a focus outline on a single item title
2 participants