Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add requestContext to Strapi interface #15212

Merged
merged 4 commits into from Dec 22, 2022

Conversation

ivanThePleasant
Copy link
Contributor

What does it do?

Adds requestContext to Stapi interface

Why is it needed?

We recently added requestContext functionality to Strapi app, but didn't add correct entry to the interface. As a result users experienced errors.

Related issue(s)/PR(s)

Let us know if this is related to any issue/pull request

@ivanThePleasant ivanThePleasant added pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: typescript Source is related to TypeScript (typings, tooling, ...) labels Dec 19, 2022
@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Base: 60.52% // Head: 60.52% // No change to project coverage 👍

Coverage data is based on head (708daec) compared to base (0118b4e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15212   +/-   ##
=======================================
  Coverage   60.52%   60.52%           
=======================================
  Files        1352     1352           
  Lines       33174    33174           
  Branches     6335     6335           
=======================================
  Hits        20078    20078           
  Misses      11264    11264           
  Partials     1832     1832           
Flag Coverage Δ
back 50.35% <ø> (ø)
front 65.09% <ø> (ø)
unit_back 50.35% <ø> (ø)
unit_front 65.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gu-stav gu-stav removed their request for review December 22, 2022 12:14
@Convly Convly merged commit 237f9bf into main Dec 22, 2022
@Convly Convly deleted the chore/request-context-interface-update branch December 22, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: typescript Source is related to TypeScript (typings, tooling, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants