Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: translations of RelationInputDataManager #15288

Merged
merged 2 commits into from
Jan 6, 2023

Conversation

ivan-ha
Copy link
Contributor

@ivan-ha ivan-ha commented Dec 29, 2022

What does it do?

Fix the translations in the RelationInputDataManager component, right now it's always showing the defaultMessage

SCR-20221229-fyg
SCR-20221229-fys
SCR-20221229-fzu

How to test it?

Go to add relation, the translation of zh should display fine

Related issue(s)/PR(s)

NIL

@codecov
Copy link

codecov bot commented Dec 29, 2022

Codecov Report

Base: 60.49% // Head: 60.48% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (e41226d) compared to base (d28ec97).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15288      +/-   ##
==========================================
- Coverage   60.49%   60.48%   -0.01%     
==========================================
  Files        1352     1352              
  Lines       33179    33176       -3     
  Branches     6340     6341       +1     
==========================================
- Hits        20070    20068       -2     
+ Misses      11273    11271       -2     
- Partials     1836     1837       +1     
Flag Coverage Δ
back 50.33% <ø> (ø)
front 65.05% <ø> (-0.01%) ⬇️
unit_back 50.33% <ø> (ø)
unit_front 65.05% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../components/GuidedTour/Modal/components/Content.js 68.42% <0.00%> (-5.27%) ⬇️
...onents/EditViewDataManagerProvider/utils/schema.js 7.46% <0.00%> (ø)
...rc/content-manager/pages/ListSettingsView/index.js 82.00% <0.00%> (+1.41%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gu-stav gu-stav self-assigned this Jan 2, 2023
@joshuaellis joshuaellis added source: core:content-manager Source is core/content-manager package pr: enhancement This PR adds or updates some part of the codebase or features labels Jan 6, 2023
Copy link
Contributor

@gu-stav gu-stav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. Thank you for the PR and being responsive 🤝 ✨

@gu-stav gu-stav merged commit 16fb8df into strapi:main Jan 6, 2023
@gu-stav gu-stav added this to the 4.5.6 milestone Jan 6, 2023
@gu-stav gu-stav added pr: chore This PR contains chore tasks (cleanups, configs, tooling...) and removed pr: enhancement This PR adds or updates some part of the codebase or features labels Jan 6, 2023
@ivan-ha ivan-ha deleted the fix/relations-i18n branch January 6, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: core:content-manager Source is core/content-manager package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants