Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add db dialect to startup info log #15509

Merged
merged 1 commit into from Jan 23, 2023

Conversation

cpaczek
Copy link
Collaborator

@cpaczek cpaczek commented Jan 20, 2023

What does it do?

Added the dialect to the startup log.

Why is it needed?

Helpful when running the same Strapi app on multiple databases

How to test it?

NA

@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Base: 50.37% // Head: 61.24% // Increases project coverage by +10.86% 🎉

Coverage data is based on head (2b87767) compared to base (feff8cd).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##             main   #15509       +/-   ##
===========================================
+ Coverage   50.37%   61.24%   +10.86%     
===========================================
  Files         292     1350     +1058     
  Lines       10310    33395    +23085     
  Branches     2286     6435     +4149     
===========================================
+ Hits         5194    20452    +15258     
- Misses       4225    11119     +6894     
- Partials      891     1824      +933     
Flag Coverage Δ
back 50.73% <ø> (+0.36%) ⬆️
front 66.00% <ø> (?)
unit_back 50.73% <ø> (+0.36%) ⬆️
unit_front 66.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/database/lib/entity-manager/regular-relations.js 10.00% <0.00%> (-0.10%) ⬇️
packages/core/database/lib/errors/index.js 100.00% <0.00%> (ø)
...s/core/strapi/lib/services/entity-service/index.js 75.00% <0.00%> (ø)
...e/pages/ApiTokens/EditView/utils/tests/dataMock.js 100.00% <0.00%> (ø)
...ons/admin/src/components/UsersPermissions/index.js 71.87% <0.00%> (ø)
...ad/admin/src/components/Breadcrumbs/Breadcrumbs.js 100.00% <0.00%> (ø)
.../admin/admin/src/content-manager/testUtils/data.js 100.00% <0.00%> (ø)
...ditPage/components/Permissions/utils/tests/data.js 100.00% <0.00%> (ø)
.../src/content-manager/utils/mergeMetasWithSchema.js 100.00% <0.00%> (ø)
...rs-permissions/admin/src/utils/cleanPermissions.js 100.00% <0.00%> (ø)
... and 1053 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Marc-Roig Marc-Roig added source: core:strapi Source is core/strapi package pr: enhancement This PR adds or updates some part of the codebase or features labels Jan 23, 2023
Copy link
Contributor

@jhoward1994 jhoward1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is a great idea!

@jhoward1994 jhoward1994 added this to the 4.6.0 milestone Jan 23, 2023
@jhoward1994 jhoward1994 merged commit 62e3f93 into strapi:main Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: enhancement This PR adds or updates some part of the codebase or features source: core:strapi Source is core/strapi package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants