Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] AddLogoDialog snapshots #15513

Merged
merged 1 commit into from Jan 20, 2023
Merged

[Fix] AddLogoDialog snapshots #15513

merged 1 commit into from Jan 20, 2023

Conversation

ronronscelestes
Copy link
Contributor

What

Update snapshots failing on AddLogoDialog

@ronronscelestes ronronscelestes added source: core:admin Source is core/admin package pr: fix This PR is fixing a bug labels Jan 20, 2023
@ronronscelestes ronronscelestes added this to the 4.6.0 milestone Jan 20, 2023
@ronronscelestes ronronscelestes changed the title [Fix] MainNav snapshots [Fix] AddLogoDialog snapshots Jan 20, 2023
@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Base: 50.76% // Head: 61.33% // Increases project coverage by +10.56% 🎉

Coverage data is based on head (922e769) compared to base (e66609e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##             main   #15513       +/-   ##
===========================================
+ Coverage   50.76%   61.33%   +10.56%     
===========================================
  Files         294     1350     +1056     
  Lines       10419    33436    +23017     
  Branches     2316     6445     +4129     
===========================================
+ Hits         5289    20507    +15218     
- Misses       4237    11109     +6872     
- Partials      893     1820      +927     
Flag Coverage Δ
back 50.76% <ø> (ø)
front 66.11% <ø> (?)
unit_back 50.76% <ø> (ø)
unit_front 66.11% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...dmin/src/components/CustomRadioGroup/components.js 0.00% <0.00%> (ø)
...18n/admin/src/components/LocaleList/LocaleTable.js 0.00% <0.00%> (ø)
...c/components/CMEditViewInjectedComponents/index.js 0.00% <0.00%> (ø)
...mponents/AutoReloadOverlayBlockerProvider/index.js 70.45% <0.00%> (ø)
...re/upload/admin/src/components/SelectTree/index.js 100.00% <0.00%> (ø)
...components/PermissionsDataManagerProvider/index.js 85.71% <0.00%> (ø)
...uilder/admin/src/components/AttributeIcon/index.js 94.28% <0.00%> (ø)
...s/core/admin/admin/src/core/utils/axiosInstance.js 76.47% <0.00%> (ø)
...es/core/admin/admin/src/hooks/useModels/reducer.js 100.00% <0.00%> (ø)
...manager/components/DynamicTable/TableRows/index.js 32.78% <0.00%> (ø)
... and 1046 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ronronscelestes ronronscelestes merged commit 7d482c8 into main Jan 20, 2023
@ronronscelestes ronronscelestes deleted the fix/MainNav-snapshots branch January 20, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix This PR is fixing a bug source: core:admin Source is core/admin package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants