Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ru.json #15525

Merged
merged 2 commits into from
Jan 30, 2023
Merged

Update ru.json #15525

merged 2 commits into from
Jan 30, 2023

Conversation

c3pxuo
Copy link
Contributor

@c3pxuo c3pxuo commented Jan 23, 2023

improved some "plural number" translations according to Russian grammar - declension of countables in Russian is headache so cannot be just put in typical ICU message format {{number, plural, =0 {...} other {...}}} (e.x. "X entries" - 0 записей, 1 запись, 21 запись, 4321 запись, 2 записи, 222 записи, 5 записей, 155 записей)

fixed some misprints and mistranslation

fixed some "plural number" translations according to Russian grammar - declension of countables in Russian is headache so cannot be just put in typical ICU message format {{number, plural, =0 {...} other {...}}} (e.x. "X entries" - 0 записей, 1 запись, 21 запись, 4321 запись, 2 записи, 222 записи, 5 записей, 155 записей)

fixed some misprints
@strapi-cla
Copy link

strapi-cla commented Jan 23, 2023

CLA assistant check
All committers have signed the CLA.

@ronronscelestes ronronscelestes self-assigned this Jan 26, 2023
@ronronscelestes ronronscelestes added source: core:admin Source is core/admin package pr: chore This PR contains chore tasks (cleanups, configs, tooling...) labels Jan 26, 2023
@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Base: 58.60% // Head: 58.60% // No change to project coverage 👍

Coverage data is based on head (0590995) compared to base (15247d1).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15525   +/-   ##
=======================================
  Coverage   58.60%   58.60%           
=======================================
  Files        1508     1508           
  Lines       38702    38702           
  Branches     7463     7463           
=======================================
  Hits        22682    22682           
  Misses      13698    13698           
  Partials     2322     2322           
Flag Coverage Δ
back 47.33% <ø> (ø)
front 66.12% <ø> (ø)
unit_back 47.33% <ø> (ø)
unit_front 66.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hide-me
Copy link
Contributor

hide-me commented Jan 27, 2023

Thank you for improvements of Russian translation ;)

Copy link
Contributor

@ronronscelestes ronronscelestes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @c3pxuo!

@ronronscelestes ronronscelestes added this to the 4.6.1 milestone Jan 30, 2023
@ronronscelestes ronronscelestes merged commit 0ff34ed into strapi:main Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: core:admin Source is core/admin package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants