Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Audit Logs feature #15536

Merged
merged 176 commits into from Jan 25, 2023
Merged

Add Audit Logs feature #15536

merged 176 commits into from Jan 25, 2023

Conversation

Feranchz
Copy link
Contributor

What does it do?

Add the Audit Logs feature to Strapi, PR authors: @madhurisandbhor @remidej @markkaylor @Feranchz

How to test it?

  • Be sure to have a valid EE license active
  • Start your Strapi application
  • Go to Settings -> Audit Logs, you will see a list with a log of events, you should see also the details of each event in a specific modal if you click the details icon at the right
  • You can create events doing general actions such as create/edit/delete content-types, users, media, roles and others...

@remidej remidej changed the title [Audit Logs] Add Audit Logs Add Audit Logs feature Jan 24, 2023
@markkaylor markkaylor removed the source: core:strapi Source is core/strapi package label Jan 24, 2023
markkaylor
markkaylor previously approved these changes Jan 24, 2023
Copy link
Contributor

@markkaylor markkaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎈

@remidej remidej added this to the 4.6.0 milestone Jan 24, 2023
@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Base: 61.63% // Head: 61.68% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (10274e4) compared to base (85a9359).
Patch coverage: 83.72% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15536      +/-   ##
==========================================
+ Coverage   61.63%   61.68%   +0.05%     
==========================================
  Files        1355     1365      +10     
  Lines       33527    33729     +202     
  Branches     6451     6472      +21     
==========================================
+ Hits        20663    20807     +144     
- Misses      11056    11107      +51     
- Partials     1808     1815       +7     
Flag Coverage Δ
back 52.16% <84.81%> (+0.35%) ⬆️
front 66.11% <71.42%> (+<0.01%) ⬆️
unit_back 52.16% <84.81%> (+0.35%) ⬆️
unit_front 66.11% <71.42%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core/admin/admin/src/index.js 0.00% <ø> (ø)
.../admin/admin/src/permissions/defaultPermissions.js 100.00% <ø> (ø)
...tent-type-builder/server/services/content-types.js 26.41% <0.00%> (-0.77%) ⬇️
packages/core/strapi/lib/utils/ee.js 21.87% <ø> (ø)
packages/core/upload/server/services/folder.js 20.93% <0.00%> (-0.76%) ⬇️
.../core/admin/admin/src/components/LeftMenu/index.js 26.38% <42.85%> (-0.09%) ⬇️
...s/core/strapi/lib/services/entity-service/index.js 74.65% <50.00%> (-0.35%) ⬇️
...s/core/admin/server/services/permission/queries.js 64.83% <70.00%> (+0.54%) ⬆️
...ckages/core/admin/ee/server/services/audit-logs.js 78.57% <78.57%> (ø)
packages/providers/audit-logs-local/lib/index.js 88.23% <88.23%> (ø)
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@remidej remidej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When looking at it with Fabien we found some things things I think we should change. Please don't merge just yet

remidej
remidej previously approved these changes Jan 25, 2023
@remidej remidej mentioned this pull request Jan 25, 2023
3 tasks
remidej
remidej previously approved these changes Jan 25, 2023
remidej
remidej previously approved these changes Jan 25, 2023
@Convly Convly merged commit de2e6f2 into main Jan 25, 2023
@Convly Convly deleted the feature/audit-logs branch January 25, 2023 18:48
@msoler75
Copy link

msoler75 commented Jan 31, 2023

I updated to the last strapi version, did yarn install, yarn build, and yarn develop.

But that menu item don't appear in Settings -> Audit Logs

Settings - Application - Google Chrome_3

"dependencies": {
    "@_sh/strapi-plugin-ckeditor": "^1.1.2",
    "@strapi/plugin-i18n": "4.6.0",
    "@strapi/plugin-users-permissions": "4.6.0",
    "@strapi/strapi": "4.6.0",
    "mysql": "2.18.1",
    "strapi-google-auth": "^0.1.2"
  },

@yanniskadiri
Copy link

@msoler75 do you have a Strapi enterprise license?

The audit logs feature is only accessible in the Strapi enterprise edition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flag: EE Issues correlates to internal EE ticket pr: feature This PR adds a new feature source: core:admin Source is core/admin package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants