Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] ML Video preview size #15552

Merged
merged 1 commit into from Jan 24, 2023
Merged

[fix] ML Video preview size #15552

merged 1 commit into from Jan 24, 2023

Conversation

ronronscelestes
Copy link
Contributor

@ronronscelestes ronronscelestes commented Jan 24, 2023

What

Update VideoPreviewWrapper to have the same width and height as the Avatar
Following the DS update

Before After
image image

@ronronscelestes ronronscelestes added source: core:upload Source is core/upload package pr: fix This PR is fixing a bug labels Jan 24, 2023
@ronronscelestes ronronscelestes added this to the 4.6.0 milestone Jan 24, 2023
@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@e1559ce). Click here to learn what that means.
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15552   +/-   ##
=======================================
  Coverage        ?   66.14%           
=======================================
  Files           ?     1058           
  Lines           ?    23027           
  Branches        ?     4125           
=======================================
  Hits            ?    15232           
  Misses          ?     6872           
  Partials        ?      923           
Flag Coverage Δ
front 66.14% <0.00%> (?)
unit_front 66.14% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...load/admin/src/components/TableList/PreviewCell.js 86.36% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ronronscelestes ronronscelestes merged commit 80d58f6 into main Jan 24, 2023
@ronronscelestes ronronscelestes deleted the fix/VideoPreview-size branch January 24, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix This PR is fixing a bug source: core:upload Source is core/upload package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants