Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browserslist: exclude dead browsers #15597

Merged
merged 1 commit into from
Jan 26, 2023
Merged

Conversation

gu-stav
Copy link
Contributor

@gu-stav gu-stav commented Jan 26, 2023

What does it do?

Excludes dead browser from the compilation target.

Why is it needed?

It ensures we are not compiling the codebase for dead browsers, such as Internet Explorer.

Overview: https://browsersl.ist/#q=last+3+major+versions%2CFirefox+ESR%2Clast+2+Opera+versions

Related issue(s)/PR(s)

Co-authored-by: Laurens Kling <laurens@goedideemedia.nl>
@gu-stav gu-stav added source: core:admin Source is core/admin package pr: enhancement This PR adds or updates some part of the codebase or features labels Jan 26, 2023
@gu-stav gu-stav added this to the 4.6.1 milestone Jan 26, 2023
@gu-stav gu-stav changed the title Browserslist: exclude dead browsers (IE) Browserslist: exclude dead browsers Jan 26, 2023
@joshuaellis
Copy link
Member

💀

@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Base: 58.60% // Head: 66.12% // Increases project coverage by +7.51% 🎉

Coverage data is based on head (39db250) compared to base (15247d1).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15597      +/-   ##
==========================================
+ Coverage   58.60%   66.12%   +7.51%     
==========================================
  Files        1508     1061     -447     
  Lines       38702    23034   -15668     
  Branches     7463     4121    -3342     
==========================================
- Hits        22682    15231    -7451     
+ Misses      13698     6880    -6818     
+ Partials     2322      923    -1399     
Flag Coverage Δ
back ?
front 66.12% <ø> (ø)
unit_back ?
unit_front 66.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/plugins/sentry/server/config.js
...ages/core/strapi/lib/load/filepath-to-prop-path.js
...kages/utils/typescript/lib/utils/resolve-outdir.js
...sfer/src/strapi/providers/local-source/entities.ts
...er/services/permission/sections-builder/section.js
...utils/typescript/lib/admin/create-tsconfig-file.js
packages/core/utils/lib/index.js
...pi/lib/services/entity-service/attributes/index.js
...er/server/controllers/validation/data-transform.js
packages/core/strapi/lib/index.js
... and 437 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@joshuaellis joshuaellis merged commit 0f8ee80 into main Jan 26, 2023
@joshuaellis joshuaellis deleted the fix/browserslist-not-dead branch January 26, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: enhancement This PR adds or updates some part of the codebase or features source: core:admin Source is core/admin package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants