Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Audit logs] Make JSON input the size of its content #15604

Merged
merged 1 commit into from
Jan 27, 2023

Conversation

markkaylor
Copy link
Contributor

What does it do?

  • Removes the fixed on on the JSONInput

Note:
The height and overflow of the Modal are defined in the DS (max-height: 60vh and overflow: auto)

Why is it needed?

  • To make reading audit logs payload easier

How to test it?

  • Create an entity that is really big, like Address
  • Go to the audit logs and open the created entry, the modal should be scrollable.

@markkaylor markkaylor self-assigned this Jan 27, 2023
@markkaylor markkaylor added source: core:admin Source is core/admin package pr: chore This PR contains chore tasks (cleanups, configs, tooling...) labels Jan 27, 2023
@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Base: 58.60% // Head: 58.60% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (e45fb7d) compared to base (15247d1).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15604   +/-   ##
=======================================
  Coverage   58.60%   58.60%           
=======================================
  Files        1508     1507    -1     
  Lines       38702    38696    -6     
  Branches     7463     7462    -1     
=======================================
- Hits        22682    22679    -3     
+ Misses      13698    13696    -2     
+ Partials     2322     2321    -1     
Flag Coverage Δ
back 47.33% <ø> (ø)
front 66.12% <ø> (+<0.01%) ⬆️
unit_back 47.33% <ø> (ø)
unit_front 66.12% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ssions/admin/src/pages/EmailTemplates/utils/api.js 77.77% <0.00%> (-5.56%) ⬇️
...ions/admin/src/pages/AdvancedSettings/utils/api.js 77.77% <0.00%> (-5.56%) ⬇️
...plugins/users-permissions/admin/src/utils/index.js 100.00% <0.00%> (ø)
...rs-permissions/admin/src/hooks/usePlugins/index.js 82.14% <0.00%> (ø)
...-permissions/admin/src/hooks/useFetchRole/index.js 74.07% <0.00%> (ø)
...ermissions/admin/src/pages/Roles/EditPage/index.js 80.35% <0.00%> (ø)
...missions/admin/src/pages/Roles/CreatePage/index.js 74.07% <0.00%> (ø)
...users-permissions/admin/src/utils/axiosInstance.js
...permissions/admin/src/pages/Providers/utils/api.js 54.54% <0.00%> (+4.54%) ⬆️
...ssions/admin/src/pages/Roles/ListPage/utils/api.js 50.00% <0.00%> (+4.54%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@remidej remidej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a small change of code, but a big leap for UX 🚀

@Convly Convly self-requested a review January 27, 2023 10:13
Copy link
Member

@Convly Convly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing this only to say thank you, Mark 🙏

@markkaylor markkaylor merged commit a3ff110 into main Jan 27, 2023
@markkaylor markkaylor deleted the chore/audit-logs-modal-scroll branch January 27, 2023 10:16
@markkaylor markkaylor added this to the 4.6.1 milestone Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: core:admin Source is core/admin package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants