Fix hasTable is undefined for schema postgres users

[petersg83]

What does it do?

Fix #15603

Why is it needed?

Users using postgres with a schema and having the double inverseBy bug (#14428) cannot start Strapi.

How to test it?

1. Create a schema in your postgres DB:

# SQL
CREATE SCHEMA myschema;

2. Set the schema in the database config ./config/database.js:

module.exports = ({ env }) => ({
  client: 'postgres',
  connection: {
    // ...
    schema: 'myschema',
    // ...
  },
});

3. Create a many-many relation between 2 content-types through the content-type builder
4. Identify the content-type schema where the previously created relation has the key mappedBy
5. Modify this schema file by replacing the key mappedBy by inversedBy
6. Restart the app
7. See that there is no error anymore

Related issue(s)/PR(s)

#15603

[codecov]

Codecov Report

Base: 59.11% // Head: 59.11% // No change to project coverage 👍

Coverage data is based on head (3707434) compared to base (7cb5e9e).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #15702   +/-   ##
=======================================
  Coverage   59.11%   59.11%           
=======================================
  Files        1502     1502           
  Lines       38360    38360           
  Branches     7385     7385           
=======================================
  Hits        22677    22677           
  Misses      13411    13411           
  Partials     2272     2272           

Flag	Coverage Δ
back	47.38% <0.00%> (ø)
front	67.15% <ø> (ø)
unit_back	47.38% <0.00%> (ø)
unit_front	67.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...atabase/lib/validations/relations/bidirectional.js	45.71% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[Marc-Roig]

LGTM!

[Marc-Roig]

Forgot we had getSchemaConnection. Good catch!

[gu-stav]

Just a random question: why is this not catched by any test? :)

[Marc-Roig]

That is a very good question and a thing we could discuss better.

This is caused by a custom configuration on postgres we didnt account for. For the default config is working ok.

We have faced multiple issues caused by db configs

GTID issues
Mariadb clusters
Postgress custom schemas

We could extend this list and periodically test for it, or see if there is a possibility to add it in the CI.

It is quite complicated to account for things like this in our current tests today.

[gu-stav]

Interesting. I imagine it would be quite hard to run all tests against every combination of configuration. Do you see a way to create tests, e.g. to mimic a specific configuration? E.g. to mock something in a way to simulate such a configuration?