[Templates] Plugin deps & Custom.d.ts #15798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuaellis
added
pr: fix
Codecov ReportBase: 58.40% // Head: 58.41% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #15798 +/- ##
=======================================
Coverage 58.40% 58.41%
=======================================
Files 1545 1545
Lines 38196 38199 +3
Branches 7512 7510 -2
=======================================
+ Hits 22309 22314 +5
+ Misses 13594 13592 -2
Partials 2293 2293
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
markkaylor
reviewed
Feb 15, 2023
packages/generators/generators/lib/files/ts/plugin/tsconfig.json
Outdated
Show resolved
Hide resolved
packages/generators/generators/lib/templates/ts/plugin-package.json.hbs
Outdated
Show resolved
Hide resolved
Co-authored-by: markkaylor <mark.kaylor@strapi.io>
….json.hbs Co-authored-by: markkaylor <mark.kaylor@strapi.io>
gu-stav
reviewed
Feb 15, 2023
|
@joshuaellis Unfortunately I don't feel comfortable to review this PR. Generators are owned by @markkaylor and @remidej and I believe they should be the ones reviewing this. |
markkaylor
reviewed
Feb 16, 2023
There was a problem hiding this comment.
When I do the following test for a TypeScript plugin:
- Generate a TypeScript plugin via
./node_modules/.bin/strapi generatein examples/getstarted - Add the plugin config
- In the TypeScript plugin run yarn && yarn build
The same test seems to work on main though 🤔
|
Should we remove |
|
@joshuaellis I'd love that. |
|
So because we don't have types for the I've also removed |
|
Size Change: 0 B Total Size: 1.54 MB ℹ️ View Unchanged
|
gu-stav
reviewed
Feb 16, 2023
markkaylor
previously approved these changes
Feb 17, 2023
markkaylor
reviewed
Feb 17, 2023
markkaylor
reviewed
Feb 17, 2023
chore: fix scripts chore: fix dev to be develop Update examples/getstarted/src/index.js Update examples/getstarted/src/index.js Co-Authored-By: markkaylor <mark.kaylor@strapi.io>
joshuaellis
force-pushed
the
fix/plugin-templates
branch
from
c6c395d
to
29761db
Compare
markkaylor
approved these changes
Feb 17, 2023
This was referenced May 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
custom.d.tsfile for Typescript plugins so it doesn't fail with our own packagesWhy is it needed?
Related issue(s)/PR(s)