Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some eu traslations removing dots #15949

Merged
merged 1 commit into from Mar 6, 2023
Merged

Conversation

sergixnet
Copy link
Contributor

What does it do?

This code allows you to configure the admin UI in Euskara and provides translations of json file in Euskara. This pull request is to fix some translations

Why is it needed?

It is necessary for Euskara-speaking regions to be able to manage the admin in their language

How to test it?

Configure src/admin/app.js file to use Euskara language:

export default {
  config: {
    locales: ['eu'],
  },
  bootstrap() {},
};

Related issue(s)/PR(s)

None

@strapi-cla
Copy link

strapi-cla commented Feb 28, 2023

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b9e92de) 60.68% compared to head (5023536) 60.68%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15949   +/-   ##
=======================================
  Coverage   60.68%   60.68%           
=======================================
  Files        1495     1495           
  Lines       36878    36878           
  Branches     7359     7359           
=======================================
  Hits        22380    22380           
  Misses      12417    12417           
  Partials     2081     2081           
Flag Coverage Δ
back 51.34% <ø> (ø)
front 66.30% <ø> (ø)
unit_back 51.34% <ø> (ø)
unit_front 66.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sergixnet sergixnet force-pushed the main branch 2 times, most recently from 9499c8f to e592e89 Compare March 1, 2023 13:14
@Marc-Roig Marc-Roig added pr: enhancement This PR adds or updates some part of the codebase or features source: core:admin Source is core/admin package labels Mar 6, 2023
@joshuaellis
Copy link
Member

Hey @sergixnet can you explain why you've made the changes? I don't speak this language but removing full-stops / periods (whatever you'd like to call them) currently seems erroneous and it'd be helpful to understand why for the future :)

@sergixnet
Copy link
Contributor Author

Hi @joshuaellis

The principal reason is because, in euskara these periods are not correct and have no sense.

@joshuaellis joshuaellis added this to the 4.7.2 milestone Mar 6, 2023
@joshuaellis joshuaellis merged commit a9fe3a0 into strapi:main Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: enhancement This PR adds or updates some part of the codebase or features source: core:admin Source is core/admin package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants