Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DS to 1.6.4 #15972

Merged
merged 1 commit into from Mar 3, 2023
Merged

Update DS to 1.6.4 #15972

merged 1 commit into from Mar 3, 2023

Conversation

joshuaellis
Copy link
Member

What does it do?

  • Updates the design-system to 1.6.4

@joshuaellis joshuaellis added source: dependencies Source is dependency problem pr: chore This PR contains chore tasks (cleanups, configs, tooling...) labels Mar 2, 2023
@joshuaellis joshuaellis added this to the 4.7.2 milestone Mar 2, 2023
@joshuaellis joshuaellis self-assigned this Mar 2, 2023
@joshuaellis
Copy link
Member Author

The change from 1em to 1rem is intended – this was introduced by Gustav in the DS.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2023

Size Change: +2.16 kB (0%)

Total Size: 1.55 MB

Filename Size Change
packages/core/admin/build/main.********.js 682 kB +2.16 kB (0%)
ℹ️ View Unchanged
Filename Size Change
packages/core/admin/build/Admin_homePage.********.chunk.js 4.19 kB 0 B
packages/core/admin/build/Admin_InternalErrorPage.********.chunk.js 533 B 0 B
packages/core/admin/build/Admin_marketplace.********.chunk.js 6.36 kB 0 B
packages/core/admin/build/Admin_pluginsPage.********.chunk.js 974 B 0 B
packages/core/admin/build/Admin_profilePage.********.chunk.js 3.04 kB 0 B
packages/core/admin/build/Admin_settingsPage.********.chunk.js 22.9 kB 0 B
packages/core/admin/build/admin-app.********.chunk.js 24.7 kB 0 B
packages/core/admin/build/Admin-authenticatedApp.********.chunk.js 8.27 kB 0 B
packages/core/admin/build/admin-edit-roles-page.********.chunk.js 1.92 kB 0 B
packages/core/admin/build/admin-edit-users.********.chunk.js 3.77 kB 0 B
packages/core/admin/build/admin-users.********.chunk.js 5.51 kB 0 B
packages/core/admin/build/api-tokens-create-page.********.chunk.js 248 B 0 B
packages/core/admin/build/api-tokens-edit-page.********.chunk.js 248 B 0 B
packages/core/admin/build/api-tokens-list-page.********.chunk.js 2.8 kB 0 B
packages/core/admin/build/ar-json.********.chunk.js 4.98 kB 0 B
packages/core/admin/build/audit-logs-settings-page.********.chunk.js 3.62 kB 0 B
packages/core/admin/build/bb3108f7fd1e6179bde1.svg 352 B 0 B
packages/core/admin/build/bb4d0d527bdfb161bc5a.svg 2.33 kB 0 B
packages/core/admin/build/ca-json.********.chunk.js 13 kB 0 B
packages/core/admin/build/content-manager.********.chunk.js 63.8 kB 0 B
packages/core/admin/build/content-type-builder-list-view.********.chunk.js 6.25 kB 0 B
packages/core/admin/build/content-type-builder-translation-ar-json.********.chunk.js 1.35 kB 0 B
packages/core/admin/build/content-type-builder-translation-cs-json.********.chunk.js 2.88 kB 0 B
packages/core/admin/build/content-type-builder-translation-de-json.********.chunk.js 4.19 kB 0 B
packages/core/admin/build/content-type-builder-translation-dk-json.********.chunk.js 3.75 kB 0 B
packages/core/admin/build/content-type-builder-translation-en-json.********.chunk.js 3.95 kB 0 B
packages/core/admin/build/content-type-builder-translation-es-json.********.chunk.js 3.98 kB 0 B
packages/core/admin/build/content-type-builder-translation-fr-json.********.chunk.js 1.66 kB 0 B
packages/core/admin/build/content-type-builder-translation-id-json.********.chunk.js 3.34 kB 0 B
packages/core/admin/build/content-type-builder-translation-it-json.********.chunk.js 3.47 kB 0 B
packages/core/admin/build/content-type-builder-translation-ja-json.********.chunk.js 1.23 kB 0 B
packages/core/admin/build/content-type-builder-translation-ko-json.********.chunk.js 4.37 kB 0 B
packages/core/admin/build/content-type-builder-translation-ms-json.********.chunk.js 3.28 kB 0 B
packages/core/admin/build/content-type-builder-translation-nl-json.********.chunk.js 3.3 kB 0 B
packages/core/admin/build/content-type-builder-translation-pl-json.********.chunk.js 4.17 kB 0 B
packages/core/admin/build/content-type-builder-translation-pt-BR-json.********.chunk.js 4.17 kB 0 B
packages/core/admin/build/content-type-builder-translation-pt-json.********.chunk.js 1.1 kB 0 B
packages/core/admin/build/content-type-builder-translation-ru-json.********.chunk.js 4.69 kB 0 B
packages/core/admin/build/content-type-builder-translation-sk-json.********.chunk.js 3.74 kB 0 B
packages/core/admin/build/content-type-builder-translation-sv-json.********.chunk.js 4.18 kB 0 B
packages/core/admin/build/content-type-builder-translation-th-json.********.chunk.js 4.36 kB 0 B
packages/core/admin/build/content-type-builder-translation-tr-json.********.chunk.js 3.84 kB 0 B
packages/core/admin/build/content-type-builder-translation-uk-json.********.chunk.js 4.37 kB 0 B
packages/core/admin/build/content-type-builder-translation-zh-Hans-json.********.chunk.js 3.5 kB 0 B
packages/core/admin/build/content-type-builder-translation-zh-json.********.chunk.js 4.5 kB 0 B
packages/core/admin/build/content-type-builder.********.chunk.js 24 kB 0 B
packages/core/admin/build/cs-json.********.chunk.js 5.88 kB 0 B
packages/core/admin/build/de-json.********.chunk.js 12.9 kB 0 B
packages/core/admin/build/dk-json.********.chunk.js 10.6 kB 0 B
packages/core/admin/build/email-settings-page.********.chunk.js 2.12 kB 0 B
packages/core/admin/build/email-translation-ar-json.********.chunk.js 122 B 0 B
packages/core/admin/build/email-translation-cs-json.********.chunk.js 121 B 0 B
packages/core/admin/build/email-translation-de-json.********.chunk.js 120 B 0 B
packages/core/admin/build/email-translation-dk-json.********.chunk.js 616 B 0 B
packages/core/admin/build/email-translation-en-json.********.chunk.js 610 B 0 B
packages/core/admin/build/email-translation-es-json.********.chunk.js 675 B 0 B
packages/core/admin/build/email-translation-fr-json.********.chunk.js 122 B 0 B
packages/core/admin/build/email-translation-id-json.********.chunk.js 122 B 0 B
packages/core/admin/build/email-translation-it-json.********.chunk.js 118 B 0 B
packages/core/admin/build/email-translation-ja-json.********.chunk.js 787 B 0 B
packages/core/admin/build/email-translation-ko-json.********.chunk.js 758 B 0 B
packages/core/admin/build/email-translation-ms-json.********.chunk.js 122 B 0 B
packages/core/admin/build/email-translation-nl-json.********.chunk.js 122 B 0 B
packages/core/admin/build/email-translation-pl-json.********.chunk.js 660 B 0 B
packages/core/admin/build/email-translation-pt-BR-json.********.chunk.js 122 B 0 B
packages/core/admin/build/email-translation-pt-json.********.chunk.js 668 B 0 B
packages/core/admin/build/email-translation-ru-json.********.chunk.js 122 B 0 B
packages/core/admin/build/email-translation-sk-json.********.chunk.js 122 B 0 B
packages/core/admin/build/email-translation-th-json.********.chunk.js 122 B 0 B
packages/core/admin/build/email-translation-tr-json.********.chunk.js 687 B 0 B
packages/core/admin/build/email-translation-uk-json.********.chunk.js 122 B 0 B
packages/core/admin/build/email-translation-vi-json.********.chunk.js 122 B 0 B
packages/core/admin/build/email-translation-zh-Hans-json.********.chunk.js 473 B 0 B
packages/core/admin/build/email-translation-zh-json.********.chunk.js 730 B 0 B
packages/core/admin/build/en-json.********.chunk.js 14.8 kB 0 B
packages/core/admin/build/es-json.********.chunk.js 14.1 kB 0 B
packages/core/admin/build/eu-json.********.chunk.js 14.3 kB 0 B
packages/core/admin/build/fr-json.********.chunk.js 11.3 kB 0 B
packages/core/admin/build/gu-json.********.chunk.js 14.4 kB 0 B
packages/core/admin/build/he-json.********.chunk.js 6.6 kB 0 B
packages/core/admin/build/hi-json.********.chunk.js 16.5 kB 0 B
packages/core/admin/build/highlight.js.********.chunk.js 842 B 0 B
packages/core/admin/build/hu-json.********.chunk.js 15.5 kB 0 B
packages/core/admin/build/i18n-settings-page.********.chunk.js 3.8 kB 0 B
packages/core/admin/build/i18n-translation-de-json.********.chunk.js 1.62 kB 0 B
packages/core/admin/build/i18n-translation-dk-json.********.chunk.js 1.62 kB 0 B
packages/core/admin/build/i18n-translation-en-json.********.chunk.js 1.55 kB 0 B
packages/core/admin/build/i18n-translation-es-json.********.chunk.js 1.68 kB 0 B
packages/core/admin/build/i18n-translation-fr-json.********.chunk.js 1.73 kB 0 B
packages/core/admin/build/i18n-translation-ko-json.********.chunk.js 1.86 kB 0 B
packages/core/admin/build/i18n-translation-pl-json.********.chunk.js 1.8 kB 0 B
packages/core/admin/build/i18n-translation-tr-json.********.chunk.js 1.7 kB 0 B
packages/core/admin/build/i18n-translation-zh-Hans-json.********.chunk.js 1.64 kB 0 B
packages/core/admin/build/i18n-translation-zh-json.********.chunk.js 1.73 kB 0 B
packages/core/admin/build/id-json.********.chunk.js 7.59 kB 0 B
packages/core/admin/build/index.html 263 B +1 B (0%)
packages/core/admin/build/it-json.********.chunk.js 8.03 kB 0 B
packages/core/admin/build/ja-json.********.chunk.js 12.3 kB 0 B
packages/core/admin/build/ko-json.********.chunk.js 11.6 kB 0 B
packages/core/admin/build/ml-json.********.chunk.js 17.4 kB 0 B
packages/core/admin/build/ms-json.********.chunk.js 6.16 kB 0 B
packages/core/admin/build/nl-json.********.chunk.js 14.4 kB 0 B
packages/core/admin/build/no-json.********.chunk.js 5.59 kB 0 B
packages/core/admin/build/pl-json.********.chunk.js 13.2 kB 0 B
packages/core/admin/build/pt-BR-json.********.chunk.js 14 kB 0 B
packages/core/admin/build/pt-json.********.chunk.js 5.71 kB 0 B
packages/core/admin/build/ru-json.********.chunk.js 20.6 kB 0 B
packages/core/admin/build/runtime~main.********.js 4.68 kB -1 B (0%)
packages/core/admin/build/sa-json.********.chunk.js 17 kB 0 B
packages/core/admin/build/sk-json.********.chunk.js 11.9 kB 0 B
packages/core/admin/build/sso-settings-page.********.chunk.js 1.5 kB 0 B
packages/core/admin/build/sv-json.********.chunk.js 14.2 kB 0 B
packages/core/admin/build/th-json.********.chunk.js 9.16 kB 0 B
packages/core/admin/build/tr-json.********.chunk.js 13.9 kB 0 B
packages/core/admin/build/transfer-tokens-create-page.********.chunk.js 251 B 0 B
packages/core/admin/build/transfer-tokens-edit-page.********.chunk.js 250 B 0 B
packages/core/admin/build/transfer-tokens-list-page.********.chunk.js 2.81 kB 0 B
packages/core/admin/build/uk-json.********.chunk.js 7.71 kB 0 B
packages/core/admin/build/Upload_ConfigureTheView.********.chunk.js 1.74 kB 0 B
packages/core/admin/build/upload-settings.********.chunk.js 1.87 kB 0 B
packages/core/admin/build/upload-translation-ca-json.********.chunk.js 2.48 kB 0 B
packages/core/admin/build/upload-translation-de-json.********.chunk.js 2.19 kB 0 B
packages/core/admin/build/upload-translation-dk-json.********.chunk.js 1.96 kB 0 B
packages/core/admin/build/upload-translation-en-json.********.chunk.js 2.58 kB 0 B
packages/core/admin/build/upload-translation-es-json.********.chunk.js 2.45 kB 0 B
packages/core/admin/build/upload-translation-fr-json.********.chunk.js 1.78 kB 0 B
packages/core/admin/build/upload-translation-he-json.********.chunk.js 1.84 kB 0 B
packages/core/admin/build/upload-translation-it-json.********.chunk.js 1.56 kB 0 B
packages/core/admin/build/upload-translation-ja-json.********.chunk.js 1.92 kB 0 B
packages/core/admin/build/upload-translation-ko-json.********.chunk.js 2.5 kB 0 B
packages/core/admin/build/upload-translation-ms-json.********.chunk.js 1.41 kB 0 B
packages/core/admin/build/upload-translation-pl-json.********.chunk.js 2.19 kB 0 B
packages/core/admin/build/upload-translation-pt-BR-json.********.chunk.js 1.61 kB 0 B
packages/core/admin/build/upload-translation-pt-json.********.chunk.js 1.61 kB 0 B
packages/core/admin/build/upload-translation-ru-json.********.chunk.js 2.02 kB 0 B
packages/core/admin/build/upload-translation-sk-json.********.chunk.js 2.58 kB 0 B
packages/core/admin/build/upload-translation-th-json.********.chunk.js 1.99 kB 0 B
packages/core/admin/build/upload-translation-tr-json.********.chunk.js 2.35 kB 0 B
packages/core/admin/build/upload-translation-uk-json.********.chunk.js 1.96 kB 0 B
packages/core/admin/build/upload-translation-zh-Hans-json.********.chunk.js 3.12 kB 0 B
packages/core/admin/build/upload-translation-zh-json.********.chunk.js 2.65 kB 0 B
packages/core/admin/build/upload.********.chunk.js 5.63 kB 0 B
packages/core/admin/build/users-advanced-settings-page.********.chunk.js 2.35 kB 0 B
packages/core/admin/build/users-email-settings-page.********.chunk.js 2.38 kB 0 B
packages/core/admin/build/users-permissions-translation-ar-json.********.chunk.js 1.51 kB 0 B
packages/core/admin/build/users-permissions-translation-cs-json.********.chunk.js 1.46 kB 0 B
packages/core/admin/build/users-permissions-translation-de-json.********.chunk.js 1.58 kB 0 B
packages/core/admin/build/users-permissions-translation-dk-json.********.chunk.js 1.92 kB 0 B
packages/core/admin/build/users-permissions-translation-en-json.********.chunk.js 1.81 kB 0 B
packages/core/admin/build/users-permissions-translation-es-json.********.chunk.js 2.05 kB 0 B
packages/core/admin/build/users-permissions-translation-fr-json.********.chunk.js 1.41 kB 0 B
packages/core/admin/build/users-permissions-translation-id-json.********.chunk.js 1.49 kB 0 B
packages/core/admin/build/users-permissions-translation-it-json.********.chunk.js 1.57 kB 0 B
packages/core/admin/build/users-permissions-translation-ja-json.********.chunk.js 1.53 kB 0 B
packages/core/admin/build/users-permissions-translation-ko-json.********.chunk.js 2.23 kB 0 B
packages/core/admin/build/users-permissions-translation-ms-json.********.chunk.js 1.27 kB 0 B
packages/core/admin/build/users-permissions-translation-nl-json.********.chunk.js 1.32 kB 0 B
packages/core/admin/build/users-permissions-translation-pl-json.********.chunk.js 2.11 kB 0 B
packages/core/admin/build/users-permissions-translation-pt-BR-json.********.chunk.js 1.21 kB 0 B
packages/core/admin/build/users-permissions-translation-pt-json.********.chunk.js 1.3 kB 0 B
packages/core/admin/build/users-permissions-translation-ru-json.********.chunk.js 2.12 kB 0 B
packages/core/admin/build/users-permissions-translation-sk-json.********.chunk.js 1.38 kB 0 B
packages/core/admin/build/users-permissions-translation-sv-json.********.chunk.js 2.01 kB 0 B
packages/core/admin/build/users-permissions-translation-th-json.********.chunk.js 2.01 kB 0 B
packages/core/admin/build/users-permissions-translation-tr-json.********.chunk.js 2.07 kB 0 B
packages/core/admin/build/users-permissions-translation-uk-json.********.chunk.js 1.75 kB 0 B
packages/core/admin/build/users-permissions-translation-vi-json.********.chunk.js 1.51 kB 0 B
packages/core/admin/build/users-permissions-translation-zh-Hans-json.********.chunk.js 1.8 kB 0 B
packages/core/admin/build/users-permissions-translation-zh-json.********.chunk.js 2.1 kB 0 B
packages/core/admin/build/users-providers-settings-page.********.chunk.js 3.43 kB 0 B
packages/core/admin/build/users-roles-settings-page.********.chunk.js 8.07 kB 0 B
packages/core/admin/build/vi-json.********.chunk.js 5.98 kB 0 B
packages/core/admin/build/webhook-edit-page.********.chunk.js 4.56 kB 0 B
packages/core/admin/build/webhook-list-page.********.chunk.js 2.5 kB 0 B
packages/core/admin/build/zh-Hans-json.********.chunk.js 13.2 kB 0 B
packages/core/admin/build/zh-json.********.chunk.js 15.2 kB 0 B
packages/core/helper-plugin/build/helper-plugin.esm.js 19.4 kB 0 B
packages/core/helper-plugin/build/helper-plugin.js 17.3 kB 0 B

compressed-size-action

@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Patch coverage has no change and project coverage change: -9.08 ⚠️

Comparison is base (63c0993) 60.68% compared to head (d209390) 51.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15972      +/-   ##
==========================================
- Coverage   60.68%   51.61%   -9.08%     
==========================================
  Files        1495      374    -1121     
  Lines       36876    14091   -22785     
  Branches     7350     3168    -4182     
==========================================
- Hits        22380     7273   -15107     
+ Misses      12415     5617    -6798     
+ Partials     2081     1201     -880     
Flag Coverage Δ
back 51.35% <ø> (ø)
front ?
unit_back 51.35% <ø> (ø)
unit_front ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...upload/admin/src/components/TableList/TableRows.js
...tViewDataManagerProvider/utils/getAPIInnerError.js
...omponents/EditAssetDialog/PreviewBox/components.js
...AuthPage/components/ForgotPasswordSuccess/index.js
...es/EditPage/components/PluginsAndSettings/index.js
...es/core/admin/admin/src/utils/checkFormValidity.js
...c/pages/AuthPage/components/ResetPassword/index.js
...permissions/admin/src/components/Policies/index.js
packages/core/upload/admin/src/index.js
...omponents/DynamicZone/components/tests/fixtures.js
... and 1111 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jhoward1994
Copy link
Contributor

Working well for me. I'm just wondering if we should change the forwardedAs prop in every use of the IconButton as you have in packages/core/upload/admin/src/components/TableList/TableRows.js

e.g. in

  • packages/core/admin/admin/src/content-manager/components/DynamicTable/TableRows/index.js
  • packages/core/upload/admin/src/pages/App/MediaLibrary/index.js

WDYT?

@joshuaellis
Copy link
Member Author

Working well for me. I'm just wondering if we should change the forwardedAs prop in every use of the IconButton as you have in packages/core/upload/admin/src/components/TableList/TableRows.js

e.g. in

  • packages/core/admin/admin/src/content-manager/components/DynamicTable/TableRows/index.js
  • packages/core/upload/admin/src/pages/App/MediaLibrary/index.js

WDYT?

I had a look at the HTML and it didn't seem to be affected, so i think we can leave as is? 🤔

@joshuaellis joshuaellis merged commit 05a8387 into main Mar 3, 2023
@joshuaellis joshuaellis deleted the chore/update-DS branch March 3, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: dependencies Source is dependency problem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants