Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only run FE unit on 18 & run build in matrix #15980

Merged
merged 2 commits into from
Mar 7, 2023
Merged

Only run FE unit on 18 & run build in matrix #15980

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b7173b
chore: only run FE unit on 18 & run build in matrix
joshuaellis Mar 3, 2023
5003a8c
chore: only build helper-plugin & admin panel
joshuaellis Mar 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
22 changes: 21 additions & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [14, 16, 18]
node: [18]
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
Expand All @@ -97,6 +97,26 @@ jobs:
directory: ./coverage
flags: front,unit_front

build:
name: 'build (node: ${{ matrix.node }})'
needs: [lint, unit_front]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this only depend on the lint job?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i thought about this, but my pov was "no point building if your tests dont pass", wdyt?

runs-on: ubuntu-latest
strategy:
matrix:
node: [14, 16, 18]
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node }}
- uses: actions/cache@v3
with:
path: '**/node_modules'
key: ${{ runner.os }}-${{ matrix.node }}-${{ hashFiles('**/yarn.lock') }}
- run: yarn install --frozen-lockfile
- name: Build
run: yarn build
joshuaellis marked this conversation as resolved.
Show resolved Hide resolved

api_ce_pg:
runs-on: ubuntu-latest
needs: [lint, unit_back, unit_front]
Expand Down