RBAC community edition update #16010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Tested so far:
- Creating a new role
- Creating a new user with new role
- Creating new content-type (with D&P and i18n)
- Applying permissions to new content-type on new role
- Applying existing conditionals
- Creating new conditional and applying it to content-type
- Validating all permissions work as intended without conditionals
- Validating all permissions work as intended with default conditionals
- Validating all permissions work as intended with custom conditional
- Validate deleting user
- Validate deleting new role
- Validating deleting one of the default roles
- Validate modifying one of the default existing roles
Errors hit:
-
Bulk deleting entries in content-type yield (as superadmin)
-
Bulk deleting entries in content-type yield (as test user in custom role)
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## releases/4.8.0 #16010 +/- ##
==================================================
- Coverage 60.68% 60.62% -0.06%
==================================================
Files 1495 1477 -18
Lines 36875 36723 -152
Branches 7358 7328 -30
==================================================
- Hits 22376 22262 -114
+ Misses 12417 12390 -27
+ Partials 2082 2071 -11
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
Size Change: -5.08 kB (0%) Total Size: 1.54 MB
ℹ️ View Unchanged
|
|
@derrickmehaffy Can you sahre the schema of the content type you used & the custom role config ? (screenshot) I can't reproduce at the moment. |
I found a few minor issues, though: The CSS of the registration form is broken The CSS of the permissions view is broken too New roles aren't listed and we need to refresh the page to see them
|
@Aurelsicoko I think this is unrelated to this PR – I will open a new one to fix it, thank you 🙏🏼 |
alexandrebodin
requested review from
Convly and
joshuaellis
and removed request for
Convly and
joshuaellis
alexandrebodin
added
source: core:admin
|
FYI @alexandrebodin Aurelien and I were able to reproduce my bug, it has to do with conditionals. I'll try to get a more detailed reproduction of the issue |
|
@derrickmehaffy I can confirm this PR doesn't introduce the bug it is already in the latest version of Strapi. Can you please open the corresponding issue for it while we release this PR for the next release :) |
Closed
Convly
reviewed
Mar 8, 2023
Convly
previously approved these changes
Mar 9, 2023
joshuaellis
previously approved these changes
Mar 9, 2023
gu-stav
reviewed
Mar 13, 2023
gu-stav
reviewed
Mar 13, 2023
packages/core/admin/admin/src/pages/SettingsPage/utils/defaultRoutes.js
Outdated
Show resolved
Hide resolved
Convly
approved these changes
Mar 14, 2023
joshuaellis
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Describe the technical changes you did.
Why is it needed?
Describe the issue you are solving.
How to test it?
Provide information about the environment and the path to verify the behaviour.
Related issue(s)/PR(s)
Let us know if this is related to any issue/pull request