Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Warning: Each child in a list should have a unique "key" prop in AssetGridList #16029

Merged
merged 1 commit into from Mar 8, 2023

Conversation

iamtofr
Copy link
Contributor

@iamtofr iamtofr commented Mar 8, 2023

What does it do?

It does fix the issue in media Library on selected tab that the was missing a key prop on return element of AssetGridList

Why is it needed?

it shows warning: Warning: Each child in a list should have a unique "key" prop.

How to test it?

open a collection with input for images. Select an image and switch to selected Files. check console for warning

Related issue(s)/PR(s)

not related

Copy link
Member

@joshuaellis joshuaellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@joshuaellis joshuaellis added source: core:upload Source is core/upload package pr: fix This PR is fixing a bug labels Mar 8, 2023
@joshuaellis joshuaellis added this to the 4.7.2 milestone Mar 8, 2023
@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (51a6c11) 60.68% compared to head (b1e105f) 60.68%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #16029   +/-   ##
=======================================
  Coverage   60.68%   60.68%           
=======================================
  Files        1495     1495           
  Lines       36876    36876           
  Branches     7359     7359           
=======================================
  Hits        22380    22380           
  Misses      12415    12415           
  Partials     2081     2081           
Flag Coverage Δ
back 51.32% <ø> (ø)
front 66.31% <ø> (ø)
unit_back 51.32% <ø> (ø)
unit_front 66.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...upload/admin/src/components/AssetGridList/index.js 85.18% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@joshuaellis joshuaellis merged commit 98632e1 into strapi:main Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix This PR is fixing a bug source: core:upload Source is core/upload package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants