-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disabled property for JSONInput (GenericInput) #16033
Disabled property for JSONInput (GenericInput) #16033
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #16033 +/- ##
==========================================
+ Coverage 60.68% 66.31% +5.62%
==========================================
Files 1495 1121 -374
Lines 36876 22798 -14078
Branches 7359 4194 -3165
==========================================
- Hits 22380 15118 -7262
+ Misses 12415 6800 -5615
+ Partials 2081 880 -1201
Flags with carried forward coverage won't be shown. Click here to find out more. see 374 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for the PR!
@alvarolozano Everything looks good, I tested and approved. I went ahead and marked your PR as ready for review to merge but you will need to assign the CLA: #16033 (comment) before I can merge. |
Done! |
What does it do?
Describe the technical changes you did.
Why is it needed?
The GenericInput component does not currently pass the disabled attribute to the JSONInput component, so for advanced use cases, it is not possible to achieve a readonly JSON field
How to test it?
Add a new GenericInput to a wiew with
type="json"
anddisabled={true}
Related issue(s)/PR(s)
FIXES #16030