Parse environment variables on build configuration #1667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maturano Is this for loading config values from environment variables for use in something like Docker? |
|
I was not thinking specifically in Docker, but I think could be also a use case. I used environment variables on the On #1590 I documented some cases and their result. I'll put the result of this PR hoping makes clear why should be included. |
|
@maturano good thinking 馃槈 |
|
@derrickmehaffy I didn't see any new comments on the original issue. I updated the description of this PR hopping having better visibility. |
lauriejim
added
pr: 馃拝 Enhancement
source: core:strapi
Move existing code to a shared library and invoke it on the build process to parse environment variables on configuration files. Looking for a consistent behavior. close #1590
|
Glad to help :) I just made a rebase with |
This was referenced Sep 19, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My PR is a: 馃悰 Bug fix
Main update on the: Framework
Currently the use of environment variables in the configuration files is allowed, however the values are not replaced building the administration panel. You can clearly see the error if you try to use an environment variable as the value of the
hostparameter in theserver.jsonfile:As can see, the value was used as an ordinary string; they were not replaced by the value of the environment variable.
This PR moves the code that makes that interpretation to
strapi-utilstrying to make it a shared functionality. In addition to been invoked originally in the same place, with this changes also it's called bywebpack, getting a consistent result in the build.You can see here the result of this change:
Notes:
strapi-utilsthe correct place? 馃close #1590