Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci improve ci time iteration 3 #16694

Closed

Conversation

belgattitude
Copy link
Contributor

@belgattitude belgattitude commented May 11, 2023

Follow up to second iteration > 45%. Now trying to reach > 55% workflow speed-up.

Warning: the only changed file is the lock, will be more apparent when parent branch is merged: #16638

In this iteration I'm trying to get rid of semver compatible duplicates (across transitive deps).

More info to come, but in general

  • the current lock have 333 duplicates.
  • meaning we install a lot of dependencies that might be redundant (ie: tslib in 6 different versions)

To see that just run

yarn dedupe --check

on master.

In my experience dealing with multiple versions leads to more complex bugs than the risk of having a bc sometimes (the nodejs ecosystem seems to be more and more strict regarding bc). Anyway upgrades will happen

This iteration is more risky of course. But as the CI is very good why not trying ?

BTW: it might have a very nice side effect on the build size as well. I'll measure

@belgattitude
Copy link
Contributor Author

belgattitude commented May 11, 2023

PS: Adding also a note about dependabot vs renovate bot...

If the deduplication works I can help moving to renovatebot (supports deduplication from the config file and much more interesting features like grouping), ie:

{
  "extends": ["config:base"],
  "enabled": true,
  "enabledManagers": ["npm", "docker-compose", "dockerfile", "github-actions"],
  "postUpdateOptions": [
    // https://docs.renovatebot.com/configuration-options/#postupdateoptions
    // Will run yarn dedupe --strategy highest
    'yarnDedupeHighest'
  ],

I'll P/R in a next iteration

@belgattitude
Copy link
Contributor Author

Closing in favour of #16764.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants