-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ci improve ci time iteration 3 #16694
Closed
belgattitude
wants to merge
10
commits into
strapi:main
from
belgattitude:ci-improve-ci-time-iteration-3
Closed
Ci improve ci time iteration 3 #16694
belgattitude
wants to merge
10
commits into
strapi:main
from
belgattitude:ci-improve-ci-time-iteration-3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case it change between yarn version 3 -> 4.
# Conflicts: # yarn.lock
# Conflicts: # yarn.lock
PS: Adding also a note about dependabot vs renovate bot... If the deduplication works I can help moving to renovatebot (supports deduplication from the config file and much more interesting features like grouping), ie: {
"extends": ["config:base"],
"enabled": true,
"enabledManagers": ["npm", "docker-compose", "dockerfile", "github-actions"],
"postUpdateOptions": [
// https://docs.renovatebot.com/configuration-options/#postupdateoptions
// Will run yarn dedupe --strategy highest
'yarnDedupeHighest'
], I'll P/R in a next iteration |
This was referenced May 11, 2023
This was referenced May 16, 2023
Closing in favour of #16764. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to second iteration > 45%. Now trying to reach > 55% workflow speed-up.
Warning: the only changed file is the lock, will be more apparent when parent branch is merged: #16638
In this iteration I'm trying to get rid of semver compatible duplicates (across transitive deps).
More info to come, but in general
To see that just run
on master.
In my experience dealing with multiple versions leads to more complex bugs than the risk of having a bc sometimes (the nodejs ecosystem seems to be more and more strict regarding bc). Anyway upgrades will happen
This iteration is more risky of course. But as the CI is very good why not trying ?
BTW: it might have a very nice side effect on the build size as well. I'll measure