CS-115: NPS Banner UI component #17485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madhurisandbhor
added
pr: feature
|
Size Change: +1.17 kB (0%) Total Size: 1.52 MB
ℹ️ View Unchanged
|
simotae14
reviewed
Jul 28, 2023
simotae14
reviewed
Jul 28, 2023
simotae14
reviewed
Jul 28, 2023
simotae14
reviewed
Jul 28, 2023
simotae14
reviewed
Jul 28, 2023
joshuaellis
reviewed
Jul 28, 2023
packages/core/admin/admin/src/components/NpsSurvey/hooks/useNpsSurveySettings.js
Outdated
Show resolved
Hide resolved
joshuaellis
requested changes
Jul 28, 2023
There was a problem hiding this comment.
Overall i'm not sure about the semantic direction, we've opted for textarea and buttons and then submit it all, do you not think this would be better as a form component overall? and then the rating is a semantically a radio-button? I don't think what you've done is "bad" I just think it can be better 💪🏼 Be interested to hear what the others think – @simotae14, @markkaylor & @gu-stav
@madhurisandbhor if it's easier for you, we can arrange a call to discuss it in more detail
packages/core/admin/admin/src/components/NpsSurvey/tests/index.test.js
Outdated
Show resolved
Hide resolved
gu-stav
reviewed
Jul 28, 2023
Feranchz
reviewed
Aug 1, 2023
gu-stav
reviewed
Aug 1, 2023
madhurisandbhor
requested review from
gu-stav,
joshuaellis,
simotae14 and
Feranchz
gu-stav
approved these changes
Aug 2, 2023
There was a problem hiding this comment.
Code-wise this is ready to go I think. Good job, @madhurisandbhor! I haven't done any functional QA yet - @Feranchz could you do that?
Feranchz
requested changes
Aug 2, 2023
There was a problem hiding this comment.
Hey @madhurisandbhor it looks nice! great work
Just one small comment:
looks like the close button is not on the square anymore
fixed |
|
Please do a squash and merge, well done @madhurisandbhor |
Feranchz
pushed a commit
that referenced
this pull request
Aug 3, 2023
* added survey rating and feedbackbox with submit button * added disabled prop for submit button * reverting disabled prop, not required * review comments updated * button replaced with radio button, wrapped in form * review comments updated * reverted display time * accessiblity changes * styles updated
Feranchz
pushed a commit
that referenced
this pull request
Aug 4, 2023
* added survey rating and feedbackbox with submit button * added disabled prop for submit button * reverting disabled prop, not required * review comments updated * button replaced with radio button, wrapped in form * review comments updated * reverted display time * accessiblity changes * styles updated
Feranchz
pushed a commit
that referenced
this pull request
Aug 4, 2023
* added survey rating and feedbackbox with submit button * added disabled prop for submit button * reverting disabled prop, not required * review comments updated * button replaced with radio button, wrapped in form * review comments updated * reverted display time * accessiblity changes * styles updated
Feranchz
pushed a commit
that referenced
this pull request
Aug 8, 2023
* added survey rating and feedbackbox with submit button * added disabled prop for submit button * reverting disabled prop, not required * review comments updated * button replaced with radio button, wrapped in form * review comments updated * reverted display time * accessiblity changes * styles updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
NPS Banner UI component added with dumb submit button.
Why is it needed?
Issue
How to test it?
If the user checked the “Keep me updated” box when registering to Strapi, then user will see the NPS survey banner with the form to fill out at the bottom of the screen.