Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List view: new cog button icon with the view settings in the list view page #17551

Merged
merged 8 commits into from
Aug 8, 2023

Conversation

simotae14
Copy link
Contributor

What does it do?

On the List View page, we would like to free up some space above the table, in the top right corner, to show only a Cog Icon that can open a menu with a link to the List View settings and checkboxes for selecting the columns to display in the List View.
Additionally, we want to add a reset button that selects the default columns of the collection.

Why is it needed?

In the list view, there are 2 elements in the top right corner of the table:

  • The columns that are currently selected
  • The cog icon that redirects to the settings of the list view (Configure the view)

We’d like to merge them to free some space in the list view.

How to test it?

  • Go the content manager and select a collection
  • On the list view you can see a Cog icon on the top right corner of the table
    • click the cog icon
      • you can click on the "Configure the view" button to go to the list view settings page of the collection
      • you can select/deselect the headers to show in the list view
      • you can click on the reset button and immediately have the default selection of the headers for the collectios

Related issue(s)/PR(s)

The ticket related is CS-42

It is a cleaned version of this PR #17528

@simotae14 simotae14 added source: core:admin Source is core/admin package pr: enhancement This PR adds or updates some part of the codebase or features labels Aug 2, 2023
@simotae14 simotae14 added this to the 4.12.2 milestone Aug 2, 2023
@simotae14 simotae14 self-assigned this Aug 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Size Change: -550 B (0%)

Total Size: 1.52 MB

Filename Size Change
packages/core/admin/build/admin-app.********.chunk.js 19.4 kB -552 B (-3%)
packages/core/admin/build/admin-edit-roles-page.********.chunk.js 16.3 kB +512 B (+3%)
packages/core/admin/build/admin-roles-list.********.chunk.js 3.09 kB +31 B (+1%)
packages/core/admin/build/content-manager.********.chunk.js 63.7 kB +178 B (0%)
packages/core/admin/build/main.********.js 581 kB -288 B (0%)
packages/core/admin/build/sso-settings-page.********.chunk.js 1.92 kB +253 B (+15%) ⚠️
packages/core/helper-plugin/build/helper-plugin.esm.js 25.3 kB -453 B (-2%)
packages/core/helper-plugin/build/helper-plugin.js 23.3 kB -253 B (-1%)
ℹ️ View Unchanged
Filename Size Change
packages/core/admin/build/Admin_homePage.********.chunk.js 8.43 kB 0 B
packages/core/admin/build/Admin_InternalErrorPage.********.chunk.js 494 B 0 B
packages/core/admin/build/Admin_marketplace.********.chunk.js 8.3 kB 0 B
packages/core/admin/build/Admin_pluginsPage.********.chunk.js 1.17 kB 0 B
packages/core/admin/build/Admin_profilePage.********.chunk.js 3.45 kB +3 B (0%)
packages/core/admin/build/Admin_settingsPage.********.chunk.js 9.07 kB +1 B (0%)
packages/core/admin/build/Admin-authenticatedApp.********.chunk.js 8.25 kB +2 B (0%)
packages/core/admin/build/admin-edit-users.********.chunk.js 4.02 kB 0 B
packages/core/admin/build/admin-users.********.chunk.js 5.76 kB 0 B
packages/core/admin/build/api-tokens-create-page.********.chunk.js 258 B 0 B
packages/core/admin/build/api-tokens-edit-page.********.chunk.js 257 B 0 B
packages/core/admin/build/api-tokens-list-page.********.chunk.js 2.85 kB 0 B
packages/core/admin/build/ar-json.********.chunk.js 19.6 kB 0 B
packages/core/admin/build/audit-logs-settings-page.********.chunk.js 4.05 kB 0 B
packages/core/admin/build/bb3108f7fd1e6179bde1.svg 352 B 0 B
packages/core/admin/build/bb4d0d527bdfb161bc5a.svg 2.33 kB 0 B
packages/core/admin/build/ca-json.********.chunk.js 13 kB 0 B
packages/core/admin/build/content-type-builder-list-view.********.chunk.js 7.17 kB 0 B
packages/core/admin/build/content-type-builder-translation-ar-json.********.chunk.js 1.37 kB 0 B
packages/core/admin/build/content-type-builder-translation-cs-json.********.chunk.js 2.89 kB 0 B
packages/core/admin/build/content-type-builder-translation-de-json.********.chunk.js 4.21 kB 0 B
packages/core/admin/build/content-type-builder-translation-dk-json.********.chunk.js 3.76 kB 0 B
packages/core/admin/build/content-type-builder-translation-en-json.********.chunk.js 4.12 kB 0 B
packages/core/admin/build/content-type-builder-translation-es-json.********.chunk.js 3.98 kB 0 B
packages/core/admin/build/content-type-builder-translation-fr-json.********.chunk.js 1.68 kB 0 B
packages/core/admin/build/content-type-builder-translation-id-json.********.chunk.js 3.35 kB 0 B
packages/core/admin/build/content-type-builder-translation-it-json.********.chunk.js 3.48 kB 0 B
packages/core/admin/build/content-type-builder-translation-ja-json.********.chunk.js 1.23 kB 0 B
packages/core/admin/build/content-type-builder-translation-ko-json.********.chunk.js 4.38 kB 0 B
packages/core/admin/build/content-type-builder-translation-ms-json.********.chunk.js 3.29 kB 0 B
packages/core/admin/build/content-type-builder-translation-nl-json.********.chunk.js 3.31 kB 0 B
packages/core/admin/build/content-type-builder-translation-pl-json.********.chunk.js 4.17 kB 0 B
packages/core/admin/build/content-type-builder-translation-pt-BR-json.********.chunk.js 4.18 kB 0 B
packages/core/admin/build/content-type-builder-translation-pt-json.********.chunk.js 1.1 kB 0 B
packages/core/admin/build/content-type-builder-translation-ru-json.********.chunk.js 4.7 kB 0 B
packages/core/admin/build/content-type-builder-translation-sk-json.********.chunk.js 3.75 kB 0 B
packages/core/admin/build/content-type-builder-translation-sv-json.********.chunk.js 4.19 kB 0 B
packages/core/admin/build/content-type-builder-translation-th-json.********.chunk.js 4.37 kB 0 B
packages/core/admin/build/content-type-builder-translation-tr-json.********.chunk.js 3.85 kB 0 B
packages/core/admin/build/content-type-builder-translation-uk-json.********.chunk.js 4.38 kB 0 B
packages/core/admin/build/content-type-builder-translation-zh-Hans-json.********.chunk.js 3.51 kB 0 B
packages/core/admin/build/content-type-builder-translation-zh-json.********.chunk.js 4.51 kB 0 B
packages/core/admin/build/content-type-builder.********.chunk.js 30.9 kB 0 B
packages/core/admin/build/cs-json.********.chunk.js 5.88 kB 0 B
packages/core/admin/build/de-json.********.chunk.js 12.8 kB 0 B
packages/core/admin/build/dk-json.********.chunk.js 10.5 kB 0 B
packages/core/admin/build/email-settings-page.********.chunk.js 3.6 kB 0 B
packages/core/admin/build/email-translation-ar-json.********.chunk.js 122 B 0 B
packages/core/admin/build/email-translation-cs-json.********.chunk.js 121 B 0 B
packages/core/admin/build/email-translation-de-json.********.chunk.js 120 B 0 B
packages/core/admin/build/email-translation-dk-json.********.chunk.js 616 B 0 B
packages/core/admin/build/email-translation-en-json.********.chunk.js 610 B 0 B
packages/core/admin/build/email-translation-es-json.********.chunk.js 675 B 0 B
packages/core/admin/build/email-translation-fr-json.********.chunk.js 122 B 0 B
packages/core/admin/build/email-translation-id-json.********.chunk.js 122 B 0 B
packages/core/admin/build/email-translation-it-json.********.chunk.js 118 B 0 B
packages/core/admin/build/email-translation-ja-json.********.chunk.js 787 B 0 B
packages/core/admin/build/email-translation-ko-json.********.chunk.js 758 B 0 B
packages/core/admin/build/email-translation-ms-json.********.chunk.js 122 B 0 B
packages/core/admin/build/email-translation-nl-json.********.chunk.js 122 B 0 B
packages/core/admin/build/email-translation-pl-json.********.chunk.js 660 B 0 B
packages/core/admin/build/email-translation-pt-BR-json.********.chunk.js 122 B 0 B
packages/core/admin/build/email-translation-pt-json.********.chunk.js 668 B 0 B
packages/core/admin/build/email-translation-ru-json.********.chunk.js 122 B 0 B
packages/core/admin/build/email-translation-sk-json.********.chunk.js 122 B 0 B
packages/core/admin/build/email-translation-th-json.********.chunk.js 122 B 0 B
packages/core/admin/build/email-translation-tr-json.********.chunk.js 687 B 0 B
packages/core/admin/build/email-translation-uk-json.********.chunk.js 122 B 0 B
packages/core/admin/build/email-translation-vi-json.********.chunk.js 122 B 0 B
packages/core/admin/build/email-translation-zh-Hans-json.********.chunk.js 473 B 0 B
packages/core/admin/build/email-translation-zh-json.********.chunk.js 730 B 0 B
packages/core/admin/build/en-json.********.chunk.js 15.6 kB +9 B (0%)
packages/core/admin/build/es-json.********.chunk.js 14.2 kB 0 B
packages/core/admin/build/eu-json.********.chunk.js 14.2 kB 0 B
packages/core/admin/build/fr-json.********.chunk.js 12.6 kB 0 B
packages/core/admin/build/gu-json.********.chunk.js 14.2 kB 0 B
packages/core/admin/build/he-json.********.chunk.js 6.48 kB 0 B
packages/core/admin/build/hi-json.********.chunk.js 16.4 kB 0 B
packages/core/admin/build/highlight.js.********.chunk.js 842 B 0 B
packages/core/admin/build/hu-json.********.chunk.js 15.4 kB 0 B
packages/core/admin/build/i18n-settings-page.********.chunk.js 4.94 kB 0 B
packages/core/admin/build/i18n-translation-de-json.********.chunk.js 1.62 kB 0 B
packages/core/admin/build/i18n-translation-dk-json.********.chunk.js 1.62 kB 0 B
packages/core/admin/build/i18n-translation-en-json.********.chunk.js 1.57 kB 0 B
packages/core/admin/build/i18n-translation-es-json.********.chunk.js 1.68 kB 0 B
packages/core/admin/build/i18n-translation-fr-json.********.chunk.js 1.73 kB 0 B
packages/core/admin/build/i18n-translation-ko-json.********.chunk.js 1.86 kB 0 B
packages/core/admin/build/i18n-translation-pl-json.********.chunk.js 1.8 kB 0 B
packages/core/admin/build/i18n-translation-ru-json.********.chunk.js 2.3 kB 0 B
packages/core/admin/build/i18n-translation-tr-json.********.chunk.js 1.7 kB 0 B
packages/core/admin/build/i18n-translation-zh-Hans-json.********.chunk.js 1.64 kB 0 B
packages/core/admin/build/i18n-translation-zh-json.********.chunk.js 1.73 kB 0 B
packages/core/admin/build/id-json.********.chunk.js 7.46 kB 0 B
packages/core/admin/build/index.html 263 B -1 B (0%)
packages/core/admin/build/it-json.********.chunk.js 7.93 kB 0 B
packages/core/admin/build/ja-json.********.chunk.js 12.3 kB 0 B
packages/core/admin/build/ko-json.********.chunk.js 11.6 kB 0 B
packages/core/admin/build/ml-json.********.chunk.js 17.3 kB 0 B
packages/core/admin/build/ms-json.********.chunk.js 6.16 kB 0 B
packages/core/admin/build/nl-json.********.chunk.js 14.4 kB 0 B
packages/core/admin/build/no-json.********.chunk.js 5.48 kB 0 B
packages/core/admin/build/pl-json.********.chunk.js 13.2 kB 0 B
packages/core/admin/build/pt-BR-json.********.chunk.js 13.9 kB 0 B
packages/core/admin/build/pt-json.********.chunk.js 5.71 kB 0 B
packages/core/admin/build/review-workflows-settings-create-view.********.chunk.js 2.08 kB 0 B
packages/core/admin/build/review-workflows-settings-edit-view.********.chunk.js 2.28 kB 0 B
packages/core/admin/build/review-workflows-settings-list-view.********.chunk.js 5.63 kB 0 B
packages/core/admin/build/ru-json.********.chunk.js 21.6 kB 0 B
packages/core/admin/build/runtime~main.********.js 4.96 kB +2 B (0%)
packages/core/admin/build/sa-json.********.chunk.js 16.9 kB 0 B
packages/core/admin/build/sk-json.********.chunk.js 11.8 kB 0 B
packages/core/admin/build/sv-json.********.chunk.js 14.1 kB 0 B
packages/core/admin/build/th-json.********.chunk.js 9.01 kB 0 B
packages/core/admin/build/tr-json.********.chunk.js 13.8 kB 0 B
packages/core/admin/build/transfer-tokens-create-page.********.chunk.js 259 B 0 B
packages/core/admin/build/transfer-tokens-edit-page.********.chunk.js 260 B 0 B
packages/core/admin/build/transfer-tokens-list-page.********.chunk.js 2.98 kB 0 B
packages/core/admin/build/uk-json.********.chunk.js 7.71 kB 0 B
packages/core/admin/build/Upload_ConfigureTheView.********.chunk.js 1.74 kB 0 B
packages/core/admin/build/upload-settings.********.chunk.js 3.08 kB 0 B
packages/core/admin/build/upload-translation-ca-json.********.chunk.js 2.48 kB 0 B
packages/core/admin/build/upload-translation-de-json.********.chunk.js 2.19 kB 0 B
packages/core/admin/build/upload-translation-dk-json.********.chunk.js 1.96 kB 0 B
packages/core/admin/build/upload-translation-en-json.********.chunk.js 2.58 kB 0 B
packages/core/admin/build/upload-translation-es-json.********.chunk.js 2.45 kB 0 B
packages/core/admin/build/upload-translation-fr-json.********.chunk.js 2.86 kB 0 B
packages/core/admin/build/upload-translation-he-json.********.chunk.js 1.84 kB 0 B
packages/core/admin/build/upload-translation-it-json.********.chunk.js 1.56 kB 0 B
packages/core/admin/build/upload-translation-ja-json.********.chunk.js 1.92 kB 0 B
packages/core/admin/build/upload-translation-ko-json.********.chunk.js 2.5 kB 0 B
packages/core/admin/build/upload-translation-ms-json.********.chunk.js 1.41 kB 0 B
packages/core/admin/build/upload-translation-pl-json.********.chunk.js 2.19 kB 0 B
packages/core/admin/build/upload-translation-pt-BR-json.********.chunk.js 1.61 kB 0 B
packages/core/admin/build/upload-translation-pt-json.********.chunk.js 1.61 kB 0 B
packages/core/admin/build/upload-translation-ru-json.********.chunk.js 2.02 kB 0 B
packages/core/admin/build/upload-translation-sk-json.********.chunk.js 2.58 kB 0 B
packages/core/admin/build/upload-translation-th-json.********.chunk.js 1.99 kB 0 B
packages/core/admin/build/upload-translation-tr-json.********.chunk.js 2.35 kB 0 B
packages/core/admin/build/upload-translation-uk-json.********.chunk.js 1.96 kB 0 B
packages/core/admin/build/upload-translation-zh-Hans-json.********.chunk.js 3.12 kB 0 B
packages/core/admin/build/upload-translation-zh-json.********.chunk.js 2.65 kB 0 B
packages/core/admin/build/upload.********.chunk.js 8.04 kB +6 B (0%)
packages/core/admin/build/users-advanced-settings-page.********.chunk.js 3.39 kB 0 B
packages/core/admin/build/users-email-settings-page.********.chunk.js 3.49 kB 0 B
packages/core/admin/build/users-permissions-translation-ar-json.********.chunk.js 1.51 kB 0 B
packages/core/admin/build/users-permissions-translation-cs-json.********.chunk.js 1.46 kB 0 B
packages/core/admin/build/users-permissions-translation-de-json.********.chunk.js 1.58 kB 0 B
packages/core/admin/build/users-permissions-translation-dk-json.********.chunk.js 1.92 kB 0 B
packages/core/admin/build/users-permissions-translation-en-json.********.chunk.js 1.81 kB 0 B
packages/core/admin/build/users-permissions-translation-es-json.********.chunk.js 2.05 kB 0 B
packages/core/admin/build/users-permissions-translation-fr-json.********.chunk.js 1.41 kB 0 B
packages/core/admin/build/users-permissions-translation-id-json.********.chunk.js 1.49 kB 0 B
packages/core/admin/build/users-permissions-translation-it-json.********.chunk.js 1.57 kB 0 B
packages/core/admin/build/users-permissions-translation-ja-json.********.chunk.js 1.53 kB 0 B
packages/core/admin/build/users-permissions-translation-ko-json.********.chunk.js 2.23 kB 0 B
packages/core/admin/build/users-permissions-translation-ms-json.********.chunk.js 1.27 kB 0 B
packages/core/admin/build/users-permissions-translation-nl-json.********.chunk.js 1.32 kB 0 B
packages/core/admin/build/users-permissions-translation-pl-json.********.chunk.js 2.11 kB 0 B
packages/core/admin/build/users-permissions-translation-pt-BR-json.********.chunk.js 1.21 kB 0 B
packages/core/admin/build/users-permissions-translation-pt-json.********.chunk.js 1.3 kB 0 B
packages/core/admin/build/users-permissions-translation-ru-json.********.chunk.js 2.75 kB 0 B
packages/core/admin/build/users-permissions-translation-sk-json.********.chunk.js 1.38 kB 0 B
packages/core/admin/build/users-permissions-translation-sv-json.********.chunk.js 2.01 kB 0 B
packages/core/admin/build/users-permissions-translation-th-json.********.chunk.js 2.01 kB 0 B
packages/core/admin/build/users-permissions-translation-tr-json.********.chunk.js 2.07 kB 0 B
packages/core/admin/build/users-permissions-translation-uk-json.********.chunk.js 1.75 kB 0 B
packages/core/admin/build/users-permissions-translation-vi-json.********.chunk.js 1.51 kB 0 B
packages/core/admin/build/users-permissions-translation-zh-Hans-json.********.chunk.js 2.19 kB 0 B
packages/core/admin/build/users-permissions-translation-zh-json.********.chunk.js 2.1 kB 0 B
packages/core/admin/build/users-providers-settings-page.********.chunk.js 5.48 kB 0 B
packages/core/admin/build/users-roles-settings-page.********.chunk.js 7.3 kB 0 B
packages/core/admin/build/vi-json.********.chunk.js 5.98 kB 0 B
packages/core/admin/build/webhook-edit-page.********.chunk.js 5.59 kB 0 B
packages/core/admin/build/webhook-list-page.********.chunk.js 3.14 kB 0 B
packages/core/admin/build/zh-Hans-json.********.chunk.js 17.2 kB 0 B
packages/core/admin/build/zh-json.********.chunk.js 15.2 kB 0 B

compressed-size-action

Feranchz
Feranchz previously approved these changes Aug 3, 2023
Copy link
Contributor

@Feranchz Feranchz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@gu-stav
Copy link
Contributor

gu-stav commented Aug 3, 2023

Quick check before we merge: does this make sense in the patch release or should this go into a minor release too, given that it doesn't fix something?

@simotae14
Copy link
Contributor Author

Thanks @Feranchz and @gu-stav . You are right @gu-stav it is better to release it in version 4.13, I am gonna change the milestone, thanks

@simotae14 simotae14 modified the milestones: 4.12.2, 4.13.0 Aug 3, 2023
gu-stav
gu-stav previously approved these changes Aug 3, 2023
Copy link
Contributor

@gu-stav gu-stav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏼

@simotae14 simotae14 dismissed stale reviews from gu-stav and Feranchz via 5ce832c August 4, 2023 07:42
@simotae14 simotae14 requested a review from gu-stav August 7, 2023 10:27
@gu-stav
Copy link
Contributor

gu-stav commented Aug 7, 2023

@simotae14 You also have to remove the import for Box :)

Copy link
Contributor

@Feranchz Feranchz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks really nice, great work 🚀

@simotae14 simotae14 merged commit e786f44 into main Aug 8, 2023
29 checks passed
@simotae14 simotae14 deleted the enhancement/list-view-view-settings-menu branch August 8, 2023 09:43
@gu-stav gu-stav removed this from the 4.13.0 milestone Aug 8, 2023
@simotae14 simotae14 restored the enhancement/list-view-view-settings-menu branch August 8, 2023 09:48
simotae14 added a commit that referenced this pull request Aug 8, 2023
@simotae14 simotae14 added this to the 4.13.0 milestone Aug 8, 2023
simotae14 added a commit that referenced this pull request Aug 8, 2023
@alexandrebodin alexandrebodin modified the milestones: 4.13.0, 4.13.1 Aug 30, 2023
@joshuaellis joshuaellis deleted the enhancement/list-view-view-settings-menu branch September 13, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: enhancement This PR adds or updates some part of the codebase or features source: core:admin Source is core/admin package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants