-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List view: new cog button icon with the view settings in the list view page #17551
Conversation
Size Change: -550 B (0%) Total Size: 1.52 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Quick check before we merge: does this make sense in the patch release or should this go into a minor release too, given that it doesn't fix something? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏🏼
packages/core/admin/admin/src/content-manager/pages/ListView/components/FieldPicker/index.js
Outdated
Show resolved
Hide resolved
packages/core/admin/admin/src/content-manager/pages/ListView/components/FieldPicker/index.js
Outdated
Show resolved
Hide resolved
packages/core/admin/admin/src/content-manager/components/AttributeFilter/Filters.js
Show resolved
Hide resolved
@simotae14 You also have to remove the import for |
...manager/pages/ListView/components/BulkActionButtons/SelectedEntriesModal/tests/index.test.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks really nice, great work 🚀
What does it do?
On the List View page, we would like to free up some space above the table, in the top right corner, to show only a Cog Icon that can open a menu with a link to the List View settings and checkboxes for selecting the columns to display in the List View.
Additionally, we want to add a reset button that selects the default columns of the collection.
Why is it needed?
In the list view, there are 2 elements in the top right corner of the table:
We’d like to merge them to free some space in the list view.
How to test it?
Related issue(s)/PR(s)
The ticket related is CS-42
It is a cleaned version of this PR #17528