feat: add auto-focussing via URLSearchParam to content-manager #17613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuaellis
added
source: core:content-manager
|
Size Change: +427 B (0%) Total Size: 1.52 MB
ℹ️ View Unchanged
|
joshuaellis
force-pushed
the
feature/focus-fields-with-field-query
branch
from
6967872
to
4ad315c
Compare
joshuaellis
removed
the
flag: don't merge
gu-stav
reviewed
Aug 9, 2023
packages/core/admin/admin/src/content-manager/components/RepeatableComponent/index.js
Outdated
Show resolved
Hide resolved
|
I've updated the description for the PR if you want to do some manual QA. |
joshuaellis
removed
the
flag: documentation
|
I've done some manual QA:
All other fields work really well 🚀 |
the field receives focus, the issue is the field imo. You either have it filled or not filled, in the case of not filled the button to add elements is nested deeply inside the field but if it's filled the first action is the one that gets focus (when you tab through the page) this inconsistency is difficult to deal with to be honest. IMHO it's a design issue that needs a rethink, e.g. could the whole field always be "seen" as a button so you can focus the whole thing and pressing enter lets you change the image etc. So for now, we focus the field and the first time you press
Really? I've just tried it and it works, this is my path |
joshuaellis
force-pushed
the
feature/focus-fields-with-field-query
branch
2 times, most recently
from
0b87583
to
f78dedd
Compare
jhoward1994
previously approved these changes
Aug 10, 2023
joshuaellis
added
the
flag: don't merge
joshuaellis
force-pushed
the
feature/focus-fields-with-field-query
branch
from
f78dedd
to
b6e4158
Compare
feat: add fieldRef to fields in GenericInput refactor: custom inputs to be focussed docs: add documentation for useFieldInputFocus hook feat: work with CM specific components feat: auto-open repeatable components feat: make wyiwyg editor focusable chore: fix other test suites test: add generic input tests for auto-focussing chore: add comment for not supported Update packages/core/admin/admin/src/content-manager/components/RepeatableComponent/index.js Co-Authored-By: Gustav Hansen <gustav.hansen@strapi.io>
joshuaellis
force-pushed
the
feature/focus-fields-with-field-query
branch
from
b6e4158
to
113b53b
Compare
joshuaellis
removed
the
flag: don't merge
|
sorry @jhoward1994 i had to rebase 🙏🏼 |
gu-stav
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
useFocusInputFieldhook exposed via thehelper-pluginuseFocusInputFieldhook to auto-focus in the content-manager inGenericInputsuseFocusInputFieldhook to auto-focus relation fields in the content-managerWYSIWGto be able to auto-focusRepeatableComponentif the field we want is located insideWhy is it needed?
How to test it?
OR
field=<name>as a query param e.g.short_textortimestamporcustom_fieldcats.0.categoriesrepeatable_compo.1. nameRelated issue(s)/PR(s)