Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default value set to false for boolean attributes #1772

Merged
merged 2 commits into from Aug 21, 2018
Merged

Conversation

soupette
Copy link
Contributor

My PR is a:
馃悰 Bug fix

Main update on the:
Plugin: content-type-builder

Allow to set false as default value for boolean attributes

@lauriejim lauriejim self-assigned this Aug 20, 2018
@lauriejim lauriejim added pr: 馃悰 Bug fix source: core:content-manager Source is core/content-manager package labels Aug 20, 2018
@lauriejim lauriejim added this to In progress in 3.0.0-alpha.14 via automation Aug 20, 2018
@lauriejim lauriejim added this to the 3.0.0-alpha.13.2 milestone Aug 20, 2018
@derrickmehaffy
Copy link
Member

@soupette thank you, I was literally pulling my hair out last night trying to figure out why some of my boolean values were defaulting to true

Copy link
Contributor

@lauriejim lauriejim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

3.0.0-alpha.14 automation moved this from In progress to Reviewer approved Aug 21, 2018
@lauriejim lauriejim merged commit 25536c8 into master Aug 21, 2018
3.0.0-alpha.14 automation moved this from Reviewer approved to Done Aug 21, 2018
@lauriejim lauriejim deleted the fix-1704 branch August 21, 2018 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source: core:content-manager Source is core/content-manager package
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants