[DTS] Only delete types of data that are being transferred #17730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cts-also-on-restore
innerdvations
added
pr: fix
packages/core/data-transfer/src/strapi/providers/local-destination/index.ts
Show resolved
Hide resolved
Bassel17
requested changes
Aug 28, 2023
packages/core/data-transfer/src/strapi/providers/local-destination/index.ts
Outdated
Show resolved
Hide resolved
packages/core/data-transfer/src/strapi/providers/local-destination/index.ts
Show resolved
Hide resolved
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
derrickmehaffy
approved these changes
Aug 28, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Update the import and transfer commands to generate the correct restore object
TODO:
refactor restore logic so it's modular and independent from local-sourceI'm skipping this one because it would be a big structural change that might break things*Why is it needed?
The initial functionality of the restore strategy causing a global reset of Strapi data caused too many users to be confused.
The updated functionality of only touching data included in a transfer matches user expectations to not touch files that are excluded in a transfer or import.
How to test it?
Using exclude or only with transfer or import should now only delete the files that are included in the process.
Related issue(s)/PR(s)
Closes #17572
Completes DX-862, DX-863, DX-864