[Feature] Entity Service types #17799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: christiancp100 <christian.capeans.perez@strapi.io>
Co-authored-by: Alexandre BODIN <alexandrebodin@users.noreply.github.com>
…api into types/entity-services/filters
…es/publication-state
…rapi/strapi into types/entity-service/data-param
Co-authored-by: Alexandre BODIN <alexandrebodin@users.noreply.github.com>
Convly
previously approved these changes
Aug 29, 2023
There was a problem hiding this comment.
LGTM
Changes regarding the initial scope
- factories have been reverted to an explicit any type for now to avoid breaking any application while we work around prototype typing issues
- Entities returned by the entity service are strongly typed (properties are narrowed based on given parameters) at the first level, but are keeping every fields for nested structures (relations, etc...)
The last two points will be worked on & shipped in later releases
|
we have some failing tests here |
Bassel17
reviewed
Aug 29, 2023
…api into features/types/entity-service
Convly
approved these changes
Aug 29, 2023
Convly
previously approved these changes
Aug 29, 2023
|
Good improvements, but createCoreController and createCoreService types are unusable now (and gives typescript errors |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Improves and adds types for the Entity Service methods
TODO before release
Why is it needed?
So types are available when using the Entity Service
How to test it?
Entity Service methods should now be typed
Typescript testing framework has been added in this PR but the tests themselves are still in progress.
Related issue(s)/PR(s)