Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ignore review workflow fields on user content type modifications check #17865

Merged
merged 5 commits into from
Aug 30, 2023

Conversation

Marc-Roig
Copy link
Contributor

@Marc-Roig Marc-Roig commented Aug 30, 2023

What does it do?

On startup we noticed the following warning:
image

This PR updates the fields to ignore when checking if the U&P User CT has been modified.

@Marc-Roig Marc-Roig added pr: fix This PR is fixing a bug source: core:review-workflows Review workflows package labels Aug 30, 2023
@Marc-Roig Marc-Roig added this to the 4.13.0 milestone Aug 30, 2023
@Marc-Roig Marc-Roig self-assigned this Aug 30, 2023
@github-actions
Copy link
Contributor

Size Change: 0 B

Total Size: 1.52 MB

ℹ️ View Unchanged
Filename Size
packages/core/admin/build/Admin_homePage.********.chunk.js 8.43 kB
packages/core/admin/build/Admin_InternalErrorPage.********.chunk.js 495 B
packages/core/admin/build/Admin_marketplace.********.chunk.js 8.29 kB
packages/core/admin/build/Admin_pluginsPage.********.chunk.js 1.17 kB
packages/core/admin/build/Admin_profilePage.********.chunk.js 3.45 kB
packages/core/admin/build/Admin_settingsPage.********.chunk.js 8.84 kB
packages/core/admin/build/admin-app.********.chunk.js 19.5 kB
packages/core/admin/build/Admin-authenticatedApp.********.chunk.js 8.27 kB
packages/core/admin/build/admin-edit-roles-page.********.chunk.js 16.3 kB
packages/core/admin/build/admin-edit-users.********.chunk.js 4.03 kB
packages/core/admin/build/admin-roles-list.********.chunk.js 3.09 kB
packages/core/admin/build/admin-users.********.chunk.js 5.77 kB
packages/core/admin/build/api-tokens-create-page.********.chunk.js 260 B
packages/core/admin/build/api-tokens-edit-page.********.chunk.js 259 B
packages/core/admin/build/api-tokens-list-page.********.chunk.js 2.79 kB
packages/core/admin/build/ar-json.********.chunk.js 19.6 kB
packages/core/admin/build/audit-logs-settings-page.********.chunk.js 4.05 kB
packages/core/admin/build/bb3108f7fd1e6179bde1.svg 352 B
packages/core/admin/build/bb4d0d527bdfb161bc5a.svg 2.33 kB
packages/core/admin/build/ca-json.********.chunk.js 13 kB
packages/core/admin/build/content-manager.********.chunk.js 64.9 kB
packages/core/admin/build/content-type-builder-list-view.********.chunk.js 7.17 kB
packages/core/admin/build/content-type-builder-translation-ar-json.********.chunk.js 1.37 kB
packages/core/admin/build/content-type-builder-translation-cs-json.********.chunk.js 2.89 kB
packages/core/admin/build/content-type-builder-translation-de-json.********.chunk.js 4.21 kB
packages/core/admin/build/content-type-builder-translation-dk-json.********.chunk.js 3.76 kB
packages/core/admin/build/content-type-builder-translation-en-json.********.chunk.js 4.12 kB
packages/core/admin/build/content-type-builder-translation-es-json.********.chunk.js 3.98 kB
packages/core/admin/build/content-type-builder-translation-fr-json.********.chunk.js 1.68 kB
packages/core/admin/build/content-type-builder-translation-id-json.********.chunk.js 3.35 kB
packages/core/admin/build/content-type-builder-translation-it-json.********.chunk.js 3.48 kB
packages/core/admin/build/content-type-builder-translation-ja-json.********.chunk.js 1.23 kB
packages/core/admin/build/content-type-builder-translation-ko-json.********.chunk.js 4.38 kB
packages/core/admin/build/content-type-builder-translation-ms-json.********.chunk.js 3.29 kB
packages/core/admin/build/content-type-builder-translation-nl-json.********.chunk.js 3.31 kB
packages/core/admin/build/content-type-builder-translation-pl-json.********.chunk.js 4.17 kB
packages/core/admin/build/content-type-builder-translation-pt-BR-json.********.chunk.js 4.18 kB
packages/core/admin/build/content-type-builder-translation-pt-json.********.chunk.js 1.1 kB
packages/core/admin/build/content-type-builder-translation-ru-json.********.chunk.js 4.7 kB
packages/core/admin/build/content-type-builder-translation-sk-json.********.chunk.js 3.75 kB
packages/core/admin/build/content-type-builder-translation-sv-json.********.chunk.js 4.19 kB
packages/core/admin/build/content-type-builder-translation-th-json.********.chunk.js 4.37 kB
packages/core/admin/build/content-type-builder-translation-tr-json.********.chunk.js 3.85 kB
packages/core/admin/build/content-type-builder-translation-uk-json.********.chunk.js 4.38 kB
packages/core/admin/build/content-type-builder-translation-zh-Hans-json.********.chunk.js 3.51 kB
packages/core/admin/build/content-type-builder-translation-zh-json.********.chunk.js 4.51 kB
packages/core/admin/build/content-type-builder.********.chunk.js 30.9 kB
packages/core/admin/build/cs-json.********.chunk.js 5.88 kB
packages/core/admin/build/de-json.********.chunk.js 12.8 kB
packages/core/admin/build/dk-json.********.chunk.js 10.5 kB
packages/core/admin/build/email-settings-page.********.chunk.js 3.32 kB
packages/core/admin/build/email-translation-ar-json.********.chunk.js 122 B
packages/core/admin/build/email-translation-cs-json.********.chunk.js 121 B
packages/core/admin/build/email-translation-de-json.********.chunk.js 120 B
packages/core/admin/build/email-translation-dk-json.********.chunk.js 616 B
packages/core/admin/build/email-translation-en-json.********.chunk.js 610 B
packages/core/admin/build/email-translation-es-json.********.chunk.js 675 B
packages/core/admin/build/email-translation-fr-json.********.chunk.js 122 B
packages/core/admin/build/email-translation-id-json.********.chunk.js 122 B
packages/core/admin/build/email-translation-it-json.********.chunk.js 118 B
packages/core/admin/build/email-translation-ja-json.********.chunk.js 787 B
packages/core/admin/build/email-translation-ko-json.********.chunk.js 758 B
packages/core/admin/build/email-translation-ms-json.********.chunk.js 122 B
packages/core/admin/build/email-translation-nl-json.********.chunk.js 122 B
packages/core/admin/build/email-translation-pl-json.********.chunk.js 660 B
packages/core/admin/build/email-translation-pt-BR-json.********.chunk.js 122 B
packages/core/admin/build/email-translation-pt-json.********.chunk.js 668 B
packages/core/admin/build/email-translation-ru-json.********.chunk.js 122 B
packages/core/admin/build/email-translation-sk-json.********.chunk.js 122 B
packages/core/admin/build/email-translation-th-json.********.chunk.js 122 B
packages/core/admin/build/email-translation-tr-json.********.chunk.js 687 B
packages/core/admin/build/email-translation-uk-json.********.chunk.js 122 B
packages/core/admin/build/email-translation-vi-json.********.chunk.js 122 B
packages/core/admin/build/email-translation-zh-Hans-json.********.chunk.js 473 B
packages/core/admin/build/email-translation-zh-json.********.chunk.js 730 B
packages/core/admin/build/en-json.********.chunk.js 15.8 kB
packages/core/admin/build/es-json.********.chunk.js 14.2 kB
packages/core/admin/build/eu-json.********.chunk.js 14.2 kB
packages/core/admin/build/fr-json.********.chunk.js 12.6 kB
packages/core/admin/build/gu-json.********.chunk.js 14.2 kB
packages/core/admin/build/he-json.********.chunk.js 6.48 kB
packages/core/admin/build/hi-json.********.chunk.js 16.4 kB
packages/core/admin/build/highlight.js.********.chunk.js 842 B
packages/core/admin/build/hu-json.********.chunk.js 15.4 kB
packages/core/admin/build/i18n-settings-page.********.chunk.js 4.94 kB
packages/core/admin/build/i18n-translation-de-json.********.chunk.js 1.62 kB
packages/core/admin/build/i18n-translation-dk-json.********.chunk.js 1.62 kB
packages/core/admin/build/i18n-translation-en-json.********.chunk.js 1.57 kB
packages/core/admin/build/i18n-translation-es-json.********.chunk.js 1.68 kB
packages/core/admin/build/i18n-translation-fr-json.********.chunk.js 1.73 kB
packages/core/admin/build/i18n-translation-ko-json.********.chunk.js 1.86 kB
packages/core/admin/build/i18n-translation-pl-json.********.chunk.js 1.8 kB
packages/core/admin/build/i18n-translation-ru-json.********.chunk.js 2.39 kB
packages/core/admin/build/i18n-translation-tr-json.********.chunk.js 1.7 kB
packages/core/admin/build/i18n-translation-zh-Hans-json.********.chunk.js 1.64 kB
packages/core/admin/build/i18n-translation-zh-json.********.chunk.js 1.73 kB
packages/core/admin/build/id-json.********.chunk.js 7.46 kB
packages/core/admin/build/index.html 262 B
packages/core/admin/build/it-json.********.chunk.js 7.93 kB
packages/core/admin/build/ja-json.********.chunk.js 12.3 kB
packages/core/admin/build/ko-json.********.chunk.js 11.6 kB
packages/core/admin/build/main.********.js 583 kB
packages/core/admin/build/ml-json.********.chunk.js 17.3 kB
packages/core/admin/build/ms-json.********.chunk.js 6.16 kB
packages/core/admin/build/nl-json.********.chunk.js 14.4 kB
packages/core/admin/build/no-json.********.chunk.js 5.48 kB
packages/core/admin/build/pl-json.********.chunk.js 13.2 kB
packages/core/admin/build/pt-BR-json.********.chunk.js 13.9 kB
packages/core/admin/build/pt-json.********.chunk.js 5.71 kB
packages/core/admin/build/review-workflows-settings-create-view.********.chunk.js 2.08 kB
packages/core/admin/build/review-workflows-settings-edit-view.********.chunk.js 2.27 kB
packages/core/admin/build/review-workflows-settings-list-view.********.chunk.js 4.8 kB
packages/core/admin/build/ru-json.********.chunk.js 21.6 kB
packages/core/admin/build/runtime~main.********.js 4.98 kB
packages/core/admin/build/sa-json.********.chunk.js 16.9 kB
packages/core/admin/build/sk-json.********.chunk.js 11.8 kB
packages/core/admin/build/sso-settings-page.********.chunk.js 1.92 kB
packages/core/admin/build/sv-json.********.chunk.js 14.1 kB
packages/core/admin/build/th-json.********.chunk.js 9.01 kB
packages/core/admin/build/tr-json.********.chunk.js 13.8 kB
packages/core/admin/build/transfer-tokens-create-page.********.chunk.js 261 B
packages/core/admin/build/transfer-tokens-edit-page.********.chunk.js 262 B
packages/core/admin/build/transfer-tokens-list-page.********.chunk.js 2.98 kB
packages/core/admin/build/uk-json.********.chunk.js 7.71 kB
packages/core/admin/build/Upload_ConfigureTheView.********.chunk.js 1.74 kB
packages/core/admin/build/upload-settings.********.chunk.js 3.08 kB
packages/core/admin/build/upload-translation-ca-json.********.chunk.js 2.48 kB
packages/core/admin/build/upload-translation-de-json.********.chunk.js 2.19 kB
packages/core/admin/build/upload-translation-dk-json.********.chunk.js 1.96 kB
packages/core/admin/build/upload-translation-en-json.********.chunk.js 2.58 kB
packages/core/admin/build/upload-translation-es-json.********.chunk.js 2.45 kB
packages/core/admin/build/upload-translation-fr-json.********.chunk.js 2.86 kB
packages/core/admin/build/upload-translation-he-json.********.chunk.js 1.84 kB
packages/core/admin/build/upload-translation-it-json.********.chunk.js 1.56 kB
packages/core/admin/build/upload-translation-ja-json.********.chunk.js 1.92 kB
packages/core/admin/build/upload-translation-ko-json.********.chunk.js 2.5 kB
packages/core/admin/build/upload-translation-ms-json.********.chunk.js 1.41 kB
packages/core/admin/build/upload-translation-pl-json.********.chunk.js 2.19 kB
packages/core/admin/build/upload-translation-pt-BR-json.********.chunk.js 1.61 kB
packages/core/admin/build/upload-translation-pt-json.********.chunk.js 1.61 kB
packages/core/admin/build/upload-translation-ru-json.********.chunk.js 2.02 kB
packages/core/admin/build/upload-translation-sk-json.********.chunk.js 2.58 kB
packages/core/admin/build/upload-translation-th-json.********.chunk.js 1.99 kB
packages/core/admin/build/upload-translation-tr-json.********.chunk.js 2.35 kB
packages/core/admin/build/upload-translation-uk-json.********.chunk.js 1.96 kB
packages/core/admin/build/upload-translation-zh-Hans-json.********.chunk.js 3.12 kB
packages/core/admin/build/upload-translation-zh-json.********.chunk.js 2.65 kB
packages/core/admin/build/upload.********.chunk.js 8.04 kB
packages/core/admin/build/users-advanced-settings-page.********.chunk.js 3.37 kB
packages/core/admin/build/users-email-settings-page.********.chunk.js 3.46 kB
packages/core/admin/build/users-permissions-translation-ar-json.********.chunk.js 1.51 kB
packages/core/admin/build/users-permissions-translation-cs-json.********.chunk.js 1.46 kB
packages/core/admin/build/users-permissions-translation-de-json.********.chunk.js 1.58 kB
packages/core/admin/build/users-permissions-translation-dk-json.********.chunk.js 1.92 kB
packages/core/admin/build/users-permissions-translation-en-json.********.chunk.js 1.81 kB
packages/core/admin/build/users-permissions-translation-es-json.********.chunk.js 2.05 kB
packages/core/admin/build/users-permissions-translation-fr-json.********.chunk.js 1.41 kB
packages/core/admin/build/users-permissions-translation-id-json.********.chunk.js 1.49 kB
packages/core/admin/build/users-permissions-translation-it-json.********.chunk.js 1.57 kB
packages/core/admin/build/users-permissions-translation-ja-json.********.chunk.js 1.53 kB
packages/core/admin/build/users-permissions-translation-ko-json.********.chunk.js 2.23 kB
packages/core/admin/build/users-permissions-translation-ms-json.********.chunk.js 1.27 kB
packages/core/admin/build/users-permissions-translation-nl-json.********.chunk.js 1.32 kB
packages/core/admin/build/users-permissions-translation-pl-json.********.chunk.js 2.11 kB
packages/core/admin/build/users-permissions-translation-pt-BR-json.********.chunk.js 1.21 kB
packages/core/admin/build/users-permissions-translation-pt-json.********.chunk.js 1.3 kB
packages/core/admin/build/users-permissions-translation-ru-json.********.chunk.js 2.75 kB
packages/core/admin/build/users-permissions-translation-sk-json.********.chunk.js 1.38 kB
packages/core/admin/build/users-permissions-translation-sv-json.********.chunk.js 2.01 kB
packages/core/admin/build/users-permissions-translation-th-json.********.chunk.js 2.01 kB
packages/core/admin/build/users-permissions-translation-tr-json.********.chunk.js 2.07 kB
packages/core/admin/build/users-permissions-translation-uk-json.********.chunk.js 1.75 kB
packages/core/admin/build/users-permissions-translation-vi-json.********.chunk.js 1.51 kB
packages/core/admin/build/users-permissions-translation-zh-Hans-json.********.chunk.js 2.19 kB
packages/core/admin/build/users-permissions-translation-zh-json.********.chunk.js 2.1 kB
packages/core/admin/build/users-providers-settings-page.********.chunk.js 4.55 kB
packages/core/admin/build/users-roles-settings-page.********.chunk.js 6.79 kB
packages/core/admin/build/vi-json.********.chunk.js 5.98 kB
packages/core/admin/build/webhook-edit-page.********.chunk.js 5.59 kB
packages/core/admin/build/webhook-list-page.********.chunk.js 3.14 kB
packages/core/admin/build/zh-Hans-json.********.chunk.js 17.1 kB
packages/core/admin/build/zh-json.********.chunk.js 15.2 kB
packages/core/helper-plugin/build/helper-plugin.esm.js 25.3 kB
packages/core/helper-plugin/build/helper-plugin.js 23.3 kB

compressed-size-action

@Marc-Roig Marc-Roig changed the title fix: remove review workflows from users and permissions fix: Ignore review workflow fields on user content type modifications check Aug 30, 2023
Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and doesn't have any impact outside the requirement

@Marc-Roig Marc-Roig merged commit e595b11 into main Aug 30, 2023
57 checks passed
@Marc-Roig Marc-Roig deleted the fix/disable-rw-on-user branch August 30, 2023 14:29
@alexandrebodin alexandrebodin modified the milestones: 4.13.0, 4.13.1 Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix This PR is fixing a bug source: core:review-workflows Review workflows package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants