-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Ignore review workflow fields on user content type modifications check #17865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marc-Roig
added
pr: fix
This PR is fixing a bug
source: core:review-workflows
Review workflows package
labels
Aug 30, 2023
Marc-Roig
requested review from
gu-stav,
alexandrebodin,
Convly and
jhoward1994
August 30, 2023 13:05
Size Change: 0 B Total Size: 1.52 MB ℹ️ View Unchanged
|
Marc-Roig
changed the title
fix: remove review workflows from users and permissions
fix: Ignore review workflow fields on user content type modifications check
Aug 30, 2023
alexandrebodin
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and doesn't have any impact outside the requirement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
On startup we noticed the following warning:
This PR updates the fields to ignore when checking if the U&P User CT has been modified.