Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core/database): add internal migrations #18437

Merged
merged 3 commits into from Oct 17, 2023

Conversation

alexandrebodin
Copy link
Member

@alexandrebodin alexandrebodin commented Oct 13, 2023

What does it do?

  • Add internal migration logic for v5
  • Add some missing tests to the migration logic

Why is it needed?

To prepare v5 migration we will need strapi to run internal migration on startup

How to test it?

You can verify user migrations are still run & you can create an internal migration and test it is running too

Related issue(s)/PR(s)

Let us know if this is related to any issue/pull request

TODO

  • Add contributor documentation for the DB internal mgirations

@alexandrebodin alexandrebodin added source: core:database Source is core/database package pr: feature This PR adds a new feature labels Oct 13, 2023
@derrickmehaffy
Copy link
Member

Finallyyyyyyyy

Copy link
Contributor

@Marc-Roig Marc-Roig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couldn't be happier to see we are going to have internal migrations 🚀

@alexandrebodin alexandrebodin merged commit 6e232b4 into v5/main Oct 17, 2023
27 of 36 checks passed
@alexandrebodin alexandrebodin added this to the 5.0.0 milestone Oct 17, 2023
@alexandrebodin alexandrebodin deleted the v5/internal-migration branch October 17, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: feature This PR adds a new feature source: core:database Source is core/database package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants