Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(admin): convert utils to TS #18452

Merged
merged 1 commit into from
Oct 19, 2023
Merged

chore(admin): convert utils to TS #18452

merged 1 commit into from
Oct 19, 2023

Conversation

gu-stav
Copy link
Contributor

@gu-stav gu-stav commented Oct 16, 2023

What does it do?

Convert top-level utils of @strapi/admin to TS.

@gu-stav gu-stav added source: core:admin Source is core/admin package pr: chore This PR contains chore tasks (cleanups, configs, tooling...) labels Oct 16, 2023
@gu-stav gu-stav added this to the 4.14.5 milestone Oct 16, 2023
@gu-stav gu-stav force-pushed the chore/utils-admin-ts branch 3 times, most recently from 9de3d4e to f67a1cd Compare October 17, 2023 09:47
@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2023 •
edited
Loading

Size Change: -2.36 kB (0%)

Total Size: 1.47 MB

Filename Size Change
packages/core/admin/build/Admin_settingsPage.********.chunk.js 8.55 kB -2.29 kB (-21%) 🎉
packages/core/admin/build/admin-app.********.chunk.js 19.9 kB -308 B (-2%)
packages/core/admin/build/Admin-authenticatedApp.********.chunk.js 8.06 kB +213 B (+3%)
packages/core/admin/build/admin-edit-users.********.chunk.js 4.05 kB +10 B (0%)
packages/core/admin/build/runtime~main.********.js 4.86 kB +14 B (0%)
ℹ️ View Unchanged
Filename Size Change
packages/core/admin/build/Admin_homePage.********.chunk.js 8.51 kB 0 B
packages/core/admin/build/Admin_InternalErrorPage.********.chunk.js 529 B 0 B
packages/core/admin/build/Admin_marketplace.********.chunk.js 6.93 kB 0 B
packages/core/admin/build/Admin_pluginsPage.********.chunk.js 1.17 kB 0 B
packages/core/admin/build/Admin_profilePage.********.chunk.js 3.44 kB +1 B (0%)
packages/core/admin/build/admin-edit-roles-page.********.chunk.js 16.3 kB 0 B
packages/core/admin/build/admin-roles-list.********.chunk.js 3.09 kB 0 B
packages/core/admin/build/admin-users.********.chunk.js 5.79 kB 0 B
packages/core/admin/build/api-tokens-create-page.********.chunk.js 260 B 0 B
packages/core/admin/build/api-tokens-edit-page.********.chunk.js 259 B 0 B
packages/core/admin/build/api-tokens-list-page.********.chunk.js 2.87 kB 0 B
packages/core/admin/build/ar-json.********.chunk.js 19.6 kB 0 B
packages/core/admin/build/audit-logs-settings-page.********.chunk.js 4.06 kB 0 B
packages/core/admin/build/bb3108f7fd1e6179bde1.svg 352 B 0 B
packages/core/admin/build/bb4d0d527bdfb161bc5a.svg 2.33 kB 0 B
packages/core/admin/build/ca-json.********.chunk.js 13 kB 0 B
packages/core/admin/build/content-manager.********.chunk.js 71.9 kB +2 B (0%)
packages/core/admin/build/content-type-builder-list-view.********.chunk.js 7.18 kB 0 B
packages/core/admin/build/content-type-builder-translation-ar-json.********.chunk.js 1.37 kB 0 B
packages/core/admin/build/content-type-builder-translation-cs-json.********.chunk.js 2.89 kB 0 B
packages/core/admin/build/content-type-builder-translation-de-json.********.chunk.js 4.21 kB 0 B
packages/core/admin/build/content-type-builder-translation-dk-json.********.chunk.js 3.76 kB 0 B
packages/core/admin/build/content-type-builder-translation-en-json.********.chunk.js 4.18 kB 0 B
packages/core/admin/build/content-type-builder-translation-es-json.********.chunk.js 3.98 kB 0 B
packages/core/admin/build/content-type-builder-translation-fr-json.********.chunk.js 1.68 kB 0 B
packages/core/admin/build/content-type-builder-translation-id-json.********.chunk.js 3.35 kB 0 B
packages/core/admin/build/content-type-builder-translation-it-json.********.chunk.js 3.48 kB 0 B
packages/core/admin/build/content-type-builder-translation-ja-json.********.chunk.js 1.23 kB 0 B
packages/core/admin/build/content-type-builder-translation-ko-json.********.chunk.js 4.38 kB 0 B
packages/core/admin/build/content-type-builder-translation-ms-json.********.chunk.js 3.29 kB 0 B
packages/core/admin/build/content-type-builder-translation-nl-json.********.chunk.js 3.31 kB 0 B
packages/core/admin/build/content-type-builder-translation-pl-json.********.chunk.js 4.17 kB 0 B
packages/core/admin/build/content-type-builder-translation-pt-BR-json.********.chunk.js 4.18 kB 0 B
packages/core/admin/build/content-type-builder-translation-pt-json.********.chunk.js 1.1 kB 0 B
packages/core/admin/build/content-type-builder-translation-ru-json.********.chunk.js 4.7 kB 0 B
packages/core/admin/build/content-type-builder-translation-sk-json.********.chunk.js 3.75 kB 0 B
packages/core/admin/build/content-type-builder-translation-sv-json.********.chunk.js 4.19 kB 0 B
packages/core/admin/build/content-type-builder-translation-th-json.********.chunk.js 4.37 kB 0 B
packages/core/admin/build/content-type-builder-translation-tr-json.********.chunk.js 3.85 kB 0 B
packages/core/admin/build/content-type-builder-translation-uk-json.********.chunk.js 4.38 kB 0 B
packages/core/admin/build/content-type-builder-translation-zh-Hans-json.********.chunk.js 3.51 kB 0 B
packages/core/admin/build/content-type-builder-translation-zh-json.********.chunk.js 4.51 kB 0 B
packages/core/admin/build/content-type-builder.********.chunk.js 27.3 kB 0 B
packages/core/admin/build/cs-json.********.chunk.js 5.88 kB 0 B
packages/core/admin/build/de-json.********.chunk.js 12.8 kB 0 B
packages/core/admin/build/dk-json.********.chunk.js 10.5 kB 0 B
packages/core/admin/build/email-settings-page.********.chunk.js 3.29 kB 0 B
packages/core/admin/build/en-json.********.chunk.js 16 kB 0 B
packages/core/admin/build/es-json.********.chunk.js 14.2 kB 0 B
packages/core/admin/build/eu-json.********.chunk.js 14.2 kB 0 B
packages/core/admin/build/fr-json.********.chunk.js 12.6 kB 0 B
packages/core/admin/build/gu-json.********.chunk.js 14.2 kB 0 B
packages/core/admin/build/he-json.********.chunk.js 6.48 kB 0 B
packages/core/admin/build/hi-json.********.chunk.js 16.4 kB 0 B
packages/core/admin/build/highlight.js.********.chunk.js 842 B 0 B
packages/core/admin/build/hu-json.********.chunk.js 15.4 kB 0 B
packages/core/admin/build/i18n-settings-page.********.chunk.js 4.95 kB 0 B
packages/core/admin/build/i18n-translation-de-json.********.chunk.js 1.62 kB 0 B
packages/core/admin/build/i18n-translation-dk-json.********.chunk.js 1.62 kB 0 B
packages/core/admin/build/i18n-translation-en-json.********.chunk.js 1.57 kB 0 B
packages/core/admin/build/i18n-translation-es-json.********.chunk.js 1.68 kB 0 B
packages/core/admin/build/i18n-translation-fr-json.********.chunk.js 1.73 kB 0 B
packages/core/admin/build/i18n-translation-ko-json.********.chunk.js 1.86 kB 0 B
packages/core/admin/build/i18n-translation-pl-json.********.chunk.js 1.8 kB 0 B
packages/core/admin/build/i18n-translation-ru-json.********.chunk.js 2.39 kB 0 B
packages/core/admin/build/i18n-translation-tr-json.********.chunk.js 1.7 kB 0 B
packages/core/admin/build/i18n-translation-zh-Hans-json.********.chunk.js 1.64 kB 0 B
packages/core/admin/build/i18n-translation-zh-json.********.chunk.js 1.73 kB 0 B
packages/core/admin/build/id-json.********.chunk.js 7.46 kB 0 B
packages/core/admin/build/index.html 264 B +1 B (0%)
packages/core/admin/build/it-json.********.chunk.js 7.93 kB 0 B
packages/core/admin/build/ja-json.********.chunk.js 12.3 kB 0 B
packages/core/admin/build/ko-json.********.chunk.js 11.6 kB 0 B
packages/core/admin/build/main.********.js 585 kB +3 B (0%)
packages/core/admin/build/ml-json.********.chunk.js 17.3 kB 0 B
packages/core/admin/build/ms-json.********.chunk.js 6.16 kB 0 B
packages/core/admin/build/nl-json.********.chunk.js 14.4 kB 0 B
packages/core/admin/build/no-json.********.chunk.js 5.48 kB 0 B
packages/core/admin/build/pl-json.********.chunk.js 13.2 kB 0 B
packages/core/admin/build/pt-BR-json.********.chunk.js 13.9 kB 0 B
packages/core/admin/build/pt-json.********.chunk.js 5.71 kB 0 B
packages/core/admin/build/review-workflows-settings-create-view.********.chunk.js 2.24 kB 0 B
packages/core/admin/build/review-workflows-settings-edit-view.********.chunk.js 2.53 kB 0 B
packages/core/admin/build/review-workflows-settings-list-view.********.chunk.js 4.88 kB 0 B
packages/core/admin/build/ru-json.********.chunk.js 21.6 kB 0 B
packages/core/admin/build/sa-json.********.chunk.js 16.9 kB 0 B
packages/core/admin/build/sk-json.********.chunk.js 11.8 kB 0 B
packages/core/admin/build/sso-settings-page.********.chunk.js 1.94 kB 0 B
packages/core/admin/build/sv-json.********.chunk.js 14.1 kB 0 B
packages/core/admin/build/th-json.********.chunk.js 9.01 kB 0 B
packages/core/admin/build/tr-json.********.chunk.js 13.8 kB 0 B
packages/core/admin/build/transfer-tokens-create-page.********.chunk.js 262 B 0 B
packages/core/admin/build/transfer-tokens-edit-page.********.chunk.js 263 B 0 B
packages/core/admin/build/transfer-tokens-list-page.********.chunk.js 3.03 kB 0 B
packages/core/admin/build/uk-json.********.chunk.js 7.71 kB 0 B
packages/core/admin/build/Upload_ConfigureTheView.********.chunk.js 1.74 kB 0 B
packages/core/admin/build/upload-settings.********.chunk.js 2.96 kB 0 B
packages/core/admin/build/upload-translation-ca-json.********.chunk.js 2.48 kB 0 B
packages/core/admin/build/upload-translation-de-json.********.chunk.js 2.19 kB 0 B
packages/core/admin/build/upload-translation-dk-json.********.chunk.js 1.96 kB 0 B
packages/core/admin/build/upload-translation-en-json.********.chunk.js 2.58 kB 0 B
packages/core/admin/build/upload-translation-es-json.********.chunk.js 2.45 kB 0 B
packages/core/admin/build/upload-translation-fr-json.********.chunk.js 2.86 kB 0 B
packages/core/admin/build/upload-translation-he-json.********.chunk.js 1.84 kB 0 B
packages/core/admin/build/upload-translation-it-json.********.chunk.js 1.56 kB 0 B
packages/core/admin/build/upload-translation-ja-json.********.chunk.js 1.92 kB 0 B
packages/core/admin/build/upload-translation-ko-json.********.chunk.js 2.5 kB 0 B
packages/core/admin/build/upload-translation-ms-json.********.chunk.js 1.41 kB 0 B
packages/core/admin/build/upload-translation-pl-json.********.chunk.js 2.19 kB 0 B
packages/core/admin/build/upload-translation-pt-BR-json.********.chunk.js 1.61 kB 0 B
packages/core/admin/build/upload-translation-pt-json.********.chunk.js 1.61 kB 0 B
packages/core/admin/build/upload-translation-ru-json.********.chunk.js 2.02 kB 0 B
packages/core/admin/build/upload-translation-sk-json.********.chunk.js 2.58 kB 0 B
packages/core/admin/build/upload-translation-th-json.********.chunk.js 1.99 kB 0 B
packages/core/admin/build/upload-translation-tr-json.********.chunk.js 2.35 kB 0 B
packages/core/admin/build/upload-translation-uk-json.********.chunk.js 1.96 kB 0 B
packages/core/admin/build/upload-translation-zh-Hans-json.********.chunk.js 3.12 kB 0 B
packages/core/admin/build/upload-translation-zh-json.********.chunk.js 2.65 kB 0 B
packages/core/admin/build/upload.********.chunk.js 8.05 kB 0 B
packages/core/admin/build/users-advanced-settings-page.********.chunk.js 3.37 kB 0 B
packages/core/admin/build/users-email-settings-page.********.chunk.js 3.46 kB 0 B
packages/core/admin/build/users-permissions-translation-ar-json.********.chunk.js 1.51 kB 0 B
packages/core/admin/build/users-permissions-translation-cs-json.********.chunk.js 1.46 kB 0 B
packages/core/admin/build/users-permissions-translation-de-json.********.chunk.js 1.58 kB 0 B
packages/core/admin/build/users-permissions-translation-dk-json.********.chunk.js 1.92 kB 0 B
packages/core/admin/build/users-permissions-translation-en-json.********.chunk.js 1.81 kB 0 B
packages/core/admin/build/users-permissions-translation-es-json.********.chunk.js 2.05 kB 0 B
packages/core/admin/build/users-permissions-translation-fr-json.********.chunk.js 1.41 kB 0 B
packages/core/admin/build/users-permissions-translation-id-json.********.chunk.js 1.49 kB 0 B
packages/core/admin/build/users-permissions-translation-it-json.********.chunk.js 1.57 kB 0 B
packages/core/admin/build/users-permissions-translation-ja-json.********.chunk.js 1.53 kB 0 B
packages/core/admin/build/users-permissions-translation-ko-json.********.chunk.js 2.23 kB 0 B
packages/core/admin/build/users-permissions-translation-ms-json.********.chunk.js 1.27 kB 0 B
packages/core/admin/build/users-permissions-translation-nl-json.********.chunk.js 1.32 kB 0 B
packages/core/admin/build/users-permissions-translation-pl-json.********.chunk.js 2.11 kB 0 B
packages/core/admin/build/users-permissions-translation-pt-BR-json.********.chunk.js 1.21 kB 0 B
packages/core/admin/build/users-permissions-translation-pt-json.********.chunk.js 1.3 kB 0 B
packages/core/admin/build/users-permissions-translation-ru-json.********.chunk.js 2.75 kB 0 B
packages/core/admin/build/users-permissions-translation-sk-json.********.chunk.js 1.38 kB 0 B
packages/core/admin/build/users-permissions-translation-sv-json.********.chunk.js 2.01 kB 0 B
packages/core/admin/build/users-permissions-translation-th-json.********.chunk.js 2.01 kB 0 B
packages/core/admin/build/users-permissions-translation-tr-json.********.chunk.js 2.07 kB 0 B
packages/core/admin/build/users-permissions-translation-uk-json.********.chunk.js 1.75 kB 0 B
packages/core/admin/build/users-permissions-translation-vi-json.********.chunk.js 1.51 kB 0 B
packages/core/admin/build/users-permissions-translation-zh-Hans-json.********.chunk.js 2.19 kB 0 B
packages/core/admin/build/users-permissions-translation-zh-json.********.chunk.js 2.1 kB 0 B
packages/core/admin/build/users-providers-settings-page.********.chunk.js 4.55 kB 0 B
packages/core/admin/build/users-roles-settings-page.********.chunk.js 6.79 kB 0 B
packages/core/admin/build/vi-json.********.chunk.js 5.98 kB 0 B
packages/core/admin/build/webhook-edit-page.********.chunk.js 5.59 kB 0 B
packages/core/admin/build/webhook-list-page.********.chunk.js 3.14 kB 0 B
packages/core/admin/build/zh-Hans-json.********.chunk.js 17.1 kB 0 B
packages/core/admin/build/zh-json.********.chunk.js 15.2 kB 0 B

compressed-size-action

@gu-stav gu-stav force-pushed the chore/utils-admin-ts branch 4 times, most recently from 9542799 to 6d64421 Compare October 17, 2023 10:51
joshuaellis
joshuaellis previously approved these changes Oct 17, 2023
View reviewed changes
@markkaylor markkaylor modified the milestones: 4.14.5, 4.14.6 Oct 18, 2023
@joshuaellis joshuaellis force-pushed the chore/utils-admin-ts branch 2 times, most recently from c30dc7e to 50a4228 Compare October 19, 2023 12:26
@joshuaellis joshuaellis self-requested a review October 19, 2023 12:36
@gu-stav @joshuaellis
chore(admin): convert utils to TS
5dc153d 
Co-authored-by: Josh Ellis <josh.ellis@strapi.io>
@gu-stav gu-stav merged commit c7672e5 into main Oct 19, 2023
27 checks passed
@gu-stav gu-stav deleted the chore/utils-admin-ts branch October 19, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuaellis joshuaellis joshuaellis approved these changes

Assignees

@gu-stav gu-stav

Labels
pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: core:admin Source is core/admin package
Projects
None yet
Milestone
4.15.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gu-stav @joshuaellis @markkaylor