Fixed padding issues in the toolbar #18570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lucasboilly
added
source: core:admin
joshuaellis
requested changes
Oct 25, 2023
Comment on lines
+50
to
+52
| min-height: unset; | ||
| padding-top: 6px; | ||
| padding-bottom: 6px; |
There was a problem hiding this comment.
why is this necessary? 🤔 please don't say to match the mock-ups 😂 I'm more asking – why isn't the design-system working in this case and why does this toolbar have to break it – you break one rule somewhere and every rule can be broken at some point === chaos.
Is something not implemented in the DS correctly?
There was a problem hiding this comment.
There was already custom modifications made on the components in the ToolBar for 2 main reasons (making it as small as possible so it doesn't waste to much space on the editing area and removing the borders around the IconButtons to avoid having multiple borders at the same place separated by small spacings). With the current Select, the Toolbar is bigger so it goes against the first point, and we end up with elements with multiple sizes in it. The cleanest thing would be of course to have more input sizes in the DS (I think we already discussed it), but in the meantime I'm sure it's easier to add another small override.
There was a problem hiding this comment.
in my opinion this is fine, we already have small style overrides here, I don't see why we'd block this one. Currently we have the worst of both worlds (style overrides and it doesn't look great)
what do you think @joshuaellis?
There was a problem hiding this comment.
Thanks for the reminder @remidej.
It's a shame we have to do this, but it shows another limitation of the DS imo. I agree, at least this is a consistent way of styling it, it'll be interesting to see if V2 is more flexible and i think this is a good case to feedback on when we get to it 👍🏼
|
Size Change: -55.5 kB (-4%) Total Size: 1.48 MB
ℹ️ View Unchanged
|
joshuaellis
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Why is it needed?
To match the mockups