fix(documentation): use correct localization schema

[ciriousjoker]

What does it do?

The generated full_documentation.json contains an error in the localizations property. The localizations property only shows up when strapi-plugin-populate-deep is also installed, but the issue is in the documentation plugin, not strapi-plugin-populate-deep.

The edited line is only hit once in the debugger and patching it seems to do exactly what I want and nothing else. It's used in production at our company.

Why is it needed?

Without this, the localization field in the schema doesn't match the actual api response. The api response contains an id & attributes, which then contain the actual data. The schema makes it seem like the localization field already contains the data.

Api response via Postman:

How to test it?

1. Clone this: https://github.com/ciriousjoker/demo_strapi_localization_field
2. Check out first, second and third commit in order
3. Notice that by switching to the forked version that matches this PR, the schema now matches the api response

Related issue(s)/PR(s)

• Fixes Documentation plugin generates incorrect localization field #18577
• This pr seems to be related, although I can't figure out if it actually caused this issue: fix #13453 Documentation Plugin doesn't generate Proper Type for the … #13458

Context

We had a pretty scuffed package-lock.json at some point, which for whatever reason produced a correct full_documentation.json schema. However, I couldn't reproduce this correct behavior when deleting the package-lock.json & the node_modules folder. In the working full_documentation.json, it used this name: ArticleListResponseDataItemLocalized, so when I had the option of choosing the suffix, I chose the one that most closely resembled the (I assume) original, correct behavior.

[strapi-cla]

All committers have signed the CLA.

[Boegie19]

Maby a stupit question but should we not check if i18n plugin is installed and enabled before we add "ListResponseDataItemLocalized" or maby make this documentation come from the i18n package.

[Boegie19]

Also @ciriousjoker Mind adding fixes: #18577 to your initial message so that it properly links the issue and your PR.

[ciriousjoker]

Do you mean adding it to the commit message or to the PR message?
I added it to the PR message now. Ping me if that's not enough.

[ciriousjoker]

Should I bother to keep this in sync with the main branch or can I do it once right before it's (hopefully) being merged?

[Boegie19]

Idk don't work for strapi soo.

[markkaylor]

I think this looks good. I'll just want to test it when I have a second later. I just had one small request 🙏 .

[ciriousjoker]

Not sure how to fix the PR labels. @markkaylor Do I need to do anything?

[ciriousjoker]

Thanks for reviewing it. Any eta for when this will be merged?