feat(blocks): add keyboard shortcuts for modifiers #18581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madhurisandbhor
added
source: core:content-manager
madhurisandbhor
changed the title
|
Size Change: -55.7 kB (-4%) Total Size: 1.48 MB
ℹ️ View Unchanged
|
remidej
reviewed
Oct 26, 2023
| * Modifier keyboard shortcuts | ||
| */ | ||
| const handleKeyboardShortcuts = (event) => { | ||
| const isMac = /Mac|iPod|iPhone|iPad/.test(navigator.userAgent); |
There was a problem hiding this comment.
The userAgent easily be modified by users (e.g. for privacy reasons). It looks like navigator.platform could be more solid
There was a problem hiding this comment.
Do you need to know? Couldn't you just look for ctrl first then cmd? Or do you both think it's too loose. My experience with user agent is it's not as reliable as you want 😓
There was a problem hiding this comment.
Navigator platform is deprecated, https://developer.mozilla.org/en-US/docs/Web/API/Navigator/platform
If we check ctrl first and then cmd, so both options will work on all the devices.
packages/core/admin/admin/src/content-manager/components/BlocksEditor/BlocksInput/index.js
Outdated
Show resolved
Hide resolved
packages/core/admin/admin/src/content-manager/components/BlocksEditor/BlocksInput/index.js
Outdated
Show resolved
Hide resolved
packages/core/admin/admin/src/content-manager/components/BlocksEditor/index.js
Show resolved
Hide resolved
...es/core/admin/admin/src/content-manager/components/BlocksEditor/plugins/withDataInsertion.js
Outdated
Show resolved
Hide resolved
remidej
reviewed
Oct 27, 2023
| * Modifier keyboard shortcuts | ||
| */ | ||
| const handleKeyboardShortcuts = (event) => { | ||
| const isCtrlOrCmd = event.metaKey || event.ctrlKey; |
There was a problem hiding this comment.
I think this would make the shortcut on windows "windows key + event.key", instead of "ctrl + event.key". Because on windows the metaKey is the windows key.
If it's confirmed then I would go back to your 1st implementation since navigator.platform is deprecated
There was a problem hiding this comment.
I would probably do the inverse of this, but pressing the windows key summons things on the OS level so I wouldn't be worried about it triggering. The issue with using a regex to detect a user agent is that you have to keep that up to date and you're actually only assuming there are two OS' which in fact for a desktop there are many iirc linux comes in many flavours.
There was a problem hiding this comment.
Agree about regex, I will confirm with product having both keys working.
There was a problem hiding this comment.
I just confirmed with Yannis, its fine to have both combinations working.
packages/core/admin/admin/src/content-manager/components/BlocksEditor/BlocksInput/index.js
Outdated
Show resolved
Hide resolved
...es/core/admin/admin/src/content-manager/components/BlocksEditor/plugins/withDataInsertion.js
Outdated
Show resolved
Hide resolved
Feranchz
reviewed
Oct 27, 2023
...es/core/admin/admin/src/content-manager/components/BlocksEditor/plugins/withDataInsertion.js
Outdated
Show resolved
Hide resolved
joshuaellis
pushed a commit
that referenced
this pull request
Nov 8, 2023
* feat: added keyboard shortcuts for modifiers * fix: eventKeys are added per modifier, updated url validation with URL() * fix: replaced eventKey with isValidEventKey() in modifier store * refactor: moved insertData to withLinks plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Added keyboard shortcuts for modifiers
How to test it?
User should be able to use common shortcuts like:
Ctrl(Cmd) + b: Transform the selection into bold.
Ctrl(Cmd) + i: Transform the selection into italic.
Ctrl(Cmd) + u: Transform the selection into underline.
Ctrl(Cmd) + v: Add a link to the selection.
Ctrl(Cmd) + e: Transform the selection into inline code.
Ctrl(Cmd) + Shift + s: Transform the selection into strikethrough.