Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(admin): convert useSettingsForm to TS #18608

Merged
merged 1 commit into from
Oct 31, 2023
Merged

chore(admin): convert useSettingsForm to TS #18608

merged 1 commit into from
Oct 31, 2023

Conversation

gu-stav
Copy link
Contributor

@gu-stav gu-stav commented Oct 30, 2023

What does it do?

Convert useSettingsForm to TS

@gu-stav gu-stav force-pushed the chore/useSettingsForm-ts branch 2 times, most recently from ec24109 to 18e6379 Compare October 30, 2023 08:08
@gu-stav gu-stav added source: core:admin Source is core/admin package pr: chore This PR contains chore tasks (cleanups, configs, tooling...) labels Oct 30, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2023 •
edited
Loading

Size Change: -2 B (0%)

Total Size: 631 kB

ℹ️ View Unchanged
Filename Size Change
examples/getstarted/build/bb4d0d527bdfb161bc5a.svg 2.33 kB 0 B
examples/getstarted/build/index.html 608 B 0 B
examples/getstarted/build/main.********.js 624 kB 0 B
examples/getstarted/build/runtime~main.********.js 4.28 kB -2 B (0%)

compressed-size-action

@gu-stav gu-stav marked this pull request as ready for review October 30, 2023 08:59
@gu-stav gu-stav added this to the 4.15.1 milestone Oct 30, 2023
jhoward1994
jhoward1994 previously approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@jhoward1994 jhoward1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I've just seen we're now missing this condition from the reducer, just want to make sure that's deliberate and not something missed?

strapi/packages/core/admin/admin/src/hooks/useSettingsForm/reducer.js

Line 33 in 9e14912

if (action.inputType === 'password' && !action.value) {

@gu-stav
Copy link
Contributor Author

gu-stav commented Oct 30, 2023

Looks good.

I've just seen we're now missing this condition from the reducer, just want to make sure that's deliberate and not something missed?

strapi/packages/core/admin/admin/src/hooks/useSettingsForm/reducer.js

Line 33 in 9e14912

if (action.inputType === 'password' && !action.value) {

I couldn't find any call which actually sets inputType (neither emptyArray). 🤷🏼

@Marc-Roig Marc-Roig modified the milestones: 4.15.1, 4.15.2 Oct 30, 2023
@joshuaellis joshuaellis merged commit 1c1e34d into main Oct 31, 2023
134 of 140 checks passed
@joshuaellis joshuaellis deleted the chore/useSettingsForm-ts branch October 31, 2023 09:22
@alexandrebodin alexandrebodin modified the milestones: 4.15.2, 4.15.3 Nov 3, 2023
joshuaellis pushed a commit that referenced this pull request Nov 8, 2023
@gu-stav @joshuaellis
chore(admin): convert useSettingsForm to TS (#18608)
96b14fa
@alexandrebodin alexandrebodin modified the milestones: 4.15.3, 4.15.2 Nov 8, 2023
@joshuaellis joshuaellis modified the milestones: 4.15.2, 4.15.5 Nov 13, 2023
@joshuaellis joshuaellis modified the milestones: 4.15.5, 4.15.2 Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuaellis joshuaellis joshuaellis approved these changes

@jhoward1994 jhoward1994 jhoward1994 left review comments

Assignees
No one assigned
Labels
pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: core:admin Source is core/admin package
Projects
None yet
Milestone
4.15.2
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gu-stav @joshuaellis @jhoward1994 @alexandrebodin @Marc-Roig