-
-
Notifications
You must be signed in to change notification settings - Fork 7.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(admin): convert useSettingsForm to TS #18608
Conversation
ec24109
to
18e6379
Compare
18e6379
to
0cd1c08
Compare
Size Change: -2 B (0%) Total Size: 631 kB ℹ️ View Unchanged
|
0cd1c08
to
6c990e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
I've just seen we're now missing this condition from the reducer, just want to make sure that's deliberate and not something missed?
if (action.inputType === 'password' && !action.value) { |
I couldn't find any call which actually sets |
packages/core/admin/ee/admin/src/pages/SettingsPage/pages/SingleSignOn/hooks/useSettingsForm.ts
Outdated
Show resolved
Hide resolved
6c990e8
to
9d15379
Compare
9d15379
to
83637d5
Compare
What does it do?
Convert
useSettingsForm
to TS