chore(admin): move constants into global constants

[gu-stav]

What does it do?

First step to move the useSettingsMenu hook to TS, to make the individual bits a bit smaller. This moves the constants into the global constants file, because: 1) it always has been weird to overwrite a constant file of a hook in EE 2) the settings menu is global.

[github-actions]

Size Change: -55.8 kB (-4%)

Total Size: 1.48 MB

Filename	Size	Change
packages/core/admin/build/Admin_settingsPage.********.chunk.js	8.35 kB	-302 B (-3%)
packages/core/admin/build/main.********.js	623 kB	-512 B (0%)
packages/core/admin/build/runtime~main.********.js	4.86 kB	-62 B (-1%)
packages/core/admin/build/strapi-plugin-cloud.********.chunk.js	0 B	-54.9 kB (removed)	🏆

ℹ️ View Unchanged

Filename	Size
packages/core/admin/build/Admin_homePage.********.chunk.js	8.32 kB
packages/core/admin/build/Admin_InternalErrorPage.********.chunk.js	526 B
packages/core/admin/build/Admin_marketplace.********.chunk.js	6.37 kB
packages/core/admin/build/Admin_pluginsPage.********.chunk.js	1.17 kB
packages/core/admin/build/Admin_profilePage.********.chunk.js	3.47 kB
packages/core/admin/build/Admin-authenticatedApp.********.chunk.js	8.03 kB
packages/core/admin/build/admin-edit-roles-page.********.chunk.js	16.2 kB
packages/core/admin/build/admin-edit-users.********.chunk.js	4.04 kB
packages/core/admin/build/admin-roles-list.********.chunk.js	3.1 kB
packages/core/admin/build/admin-users.********.chunk.js	5.79 kB
packages/core/admin/build/api-tokens-create-page.********.chunk.js	260 B
packages/core/admin/build/api-tokens-edit-page.********.chunk.js	259 B
packages/core/admin/build/api-tokens-list-page.********.chunk.js	2.87 kB
packages/core/admin/build/ar-json.********.chunk.js	19.6 kB
packages/core/admin/build/audit-logs-sales-page.********.chunk.js	628 B
packages/core/admin/build/audit-logs-settings-page.********.chunk.js	4.06 kB
packages/core/admin/build/bb4d0d527bdfb161bc5a.svg	2.33 kB
packages/core/admin/build/ca-json.********.chunk.js	13 kB
packages/core/admin/build/content-manager.********.chunk.js	72 kB
packages/core/admin/build/content-type-builder-list-view.********.chunk.js	6.35 kB
packages/core/admin/build/content-type-builder-translation-ar-json.********.chunk.js	1.37 kB
packages/core/admin/build/content-type-builder-translation-cs-json.********.chunk.js	2.89 kB
packages/core/admin/build/content-type-builder-translation-de-json.********.chunk.js	4.21 kB
packages/core/admin/build/content-type-builder-translation-dk-json.********.chunk.js	3.76 kB
packages/core/admin/build/content-type-builder-translation-en-json.********.chunk.js	4.16 kB
packages/core/admin/build/content-type-builder-translation-es-json.********.chunk.js	3.98 kB
packages/core/admin/build/content-type-builder-translation-fr-json.********.chunk.js	1.68 kB
packages/core/admin/build/content-type-builder-translation-id-json.********.chunk.js	3.35 kB
packages/core/admin/build/content-type-builder-translation-it-json.********.chunk.js	3.48 kB
packages/core/admin/build/content-type-builder-translation-ja-json.********.chunk.js	1.23 kB
packages/core/admin/build/content-type-builder-translation-ko-json.********.chunk.js	4.38 kB
packages/core/admin/build/content-type-builder-translation-ms-json.********.chunk.js	3.29 kB
packages/core/admin/build/content-type-builder-translation-nl-json.********.chunk.js	3.31 kB
packages/core/admin/build/content-type-builder-translation-pl-json.********.chunk.js	4.17 kB
packages/core/admin/build/content-type-builder-translation-pt-BR-json.********.chunk.js	4.18 kB
packages/core/admin/build/content-type-builder-translation-pt-json.********.chunk.js	1.1 kB
packages/core/admin/build/content-type-builder-translation-ru-json.********.chunk.js	4.7 kB
packages/core/admin/build/content-type-builder-translation-sk-json.********.chunk.js	3.75 kB
packages/core/admin/build/content-type-builder-translation-sv-json.********.chunk.js	4.19 kB
packages/core/admin/build/content-type-builder-translation-th-json.********.chunk.js	4.37 kB
packages/core/admin/build/content-type-builder-translation-tr-json.********.chunk.js	3.85 kB
packages/core/admin/build/content-type-builder-translation-uk-json.********.chunk.js	4.38 kB
packages/core/admin/build/content-type-builder-translation-zh-Hans-json.********.chunk.js	3.51 kB
packages/core/admin/build/content-type-builder-translation-zh-json.********.chunk.js	4.51 kB
packages/core/admin/build/content-type-builder.********.chunk.js	27.1 kB
packages/core/admin/build/cs-json.********.chunk.js	5.88 kB
packages/core/admin/build/de-json.********.chunk.js	12.8 kB
packages/core/admin/build/dk-json.********.chunk.js	10.5 kB
packages/core/admin/build/email-settings-page.********.chunk.js	2.26 kB
packages/core/admin/build/en-json.********.chunk.js	16.1 kB
packages/core/admin/build/es-json.********.chunk.js	14.2 kB
packages/core/admin/build/eu-json.********.chunk.js	14.2 kB
packages/core/admin/build/fr-json.********.chunk.js	12.6 kB
packages/core/admin/build/gu-json.********.chunk.js	14.2 kB
packages/core/admin/build/he-json.********.chunk.js	6.48 kB
packages/core/admin/build/hi-json.********.chunk.js	16.4 kB
packages/core/admin/build/highlight.js.********.chunk.js	842 B
packages/core/admin/build/hu-json.********.chunk.js	15.4 kB
packages/core/admin/build/i18n-settings-page.********.chunk.js	3.88 kB
packages/core/admin/build/i18n-translation-de-json.********.chunk.js	1.62 kB
packages/core/admin/build/i18n-translation-dk-json.********.chunk.js	1.62 kB
packages/core/admin/build/i18n-translation-en-json.********.chunk.js	1.57 kB
packages/core/admin/build/i18n-translation-es-json.********.chunk.js	1.68 kB
packages/core/admin/build/i18n-translation-fr-json.********.chunk.js	1.73 kB
packages/core/admin/build/i18n-translation-ko-json.********.chunk.js	1.86 kB
packages/core/admin/build/i18n-translation-pl-json.********.chunk.js	1.8 kB
packages/core/admin/build/i18n-translation-ru-json.********.chunk.js	2.39 kB
packages/core/admin/build/i18n-translation-tr-json.********.chunk.js	1.7 kB
packages/core/admin/build/i18n-translation-zh-Hans-json.********.chunk.js	1.64 kB
packages/core/admin/build/i18n-translation-zh-json.********.chunk.js	1.73 kB
packages/core/admin/build/id-json.********.chunk.js	7.46 kB
packages/core/admin/build/index.html	264 B
packages/core/admin/build/it-json.********.chunk.js	7.93 kB
packages/core/admin/build/ja-json.********.chunk.js	12.3 kB
packages/core/admin/build/ko-json.********.chunk.js	11.6 kB
packages/core/admin/build/ml-json.********.chunk.js	17.3 kB
packages/core/admin/build/ms-json.********.chunk.js	6.16 kB
packages/core/admin/build/nl-json.********.chunk.js	14.4 kB
packages/core/admin/build/no-json.********.chunk.js	5.48 kB
packages/core/admin/build/pl-json.********.chunk.js	13.2 kB
packages/core/admin/build/pt-BR-json.********.chunk.js	13.9 kB
packages/core/admin/build/pt-json.********.chunk.js	5.71 kB
packages/core/admin/build/review-workflows-sales-page.********.chunk.js	594 B
packages/core/admin/build/review-workflows-settings-create-view.********.chunk.js	2.24 kB
packages/core/admin/build/review-workflows-settings-edit-view.********.chunk.js	2.53 kB
packages/core/admin/build/review-workflows-settings-list-view.********.chunk.js	5.26 kB
packages/core/admin/build/ru-json.********.chunk.js	21.6 kB
packages/core/admin/build/sa-json.********.chunk.js	16.9 kB
packages/core/admin/build/sk-json.********.chunk.js	11.8 kB
packages/core/admin/build/sso-sales-page.********.chunk.js	610 B
packages/core/admin/build/sso-settings-page.********.chunk.js	1.94 kB
packages/core/admin/build/sv-json.********.chunk.js	14.1 kB
packages/core/admin/build/th-json.********.chunk.js	9.01 kB
packages/core/admin/build/tr-json.********.chunk.js	13.8 kB
packages/core/admin/build/transfer-tokens-create-page.********.chunk.js	261 B
packages/core/admin/build/transfer-tokens-edit-page.********.chunk.js	262 B
packages/core/admin/build/transfer-tokens-list-page.********.chunk.js	3.03 kB
packages/core/admin/build/uk-json.********.chunk.js	7.71 kB
packages/core/admin/build/Upload_ConfigureTheView.********.chunk.js	1.74 kB
packages/core/admin/build/upload-settings.********.chunk.js	1.93 kB
packages/core/admin/build/upload-translation-ca-json.********.chunk.js	2.48 kB
packages/core/admin/build/upload-translation-de-json.********.chunk.js	2.19 kB
packages/core/admin/build/upload-translation-dk-json.********.chunk.js	1.96 kB
packages/core/admin/build/upload-translation-en-json.********.chunk.js	2.58 kB
packages/core/admin/build/upload-translation-es-json.********.chunk.js	2.45 kB
packages/core/admin/build/upload-translation-fr-json.********.chunk.js	2.86 kB
packages/core/admin/build/upload-translation-he-json.********.chunk.js	1.84 kB
packages/core/admin/build/upload-translation-it-json.********.chunk.js	1.56 kB
packages/core/admin/build/upload-translation-ja-json.********.chunk.js	1.92 kB
packages/core/admin/build/upload-translation-ko-json.********.chunk.js	2.5 kB
packages/core/admin/build/upload-translation-ms-json.********.chunk.js	1.41 kB
packages/core/admin/build/upload-translation-pl-json.********.chunk.js	2.19 kB
packages/core/admin/build/upload-translation-pt-BR-json.********.chunk.js	1.61 kB
packages/core/admin/build/upload-translation-pt-json.********.chunk.js	1.61 kB
packages/core/admin/build/upload-translation-ru-json.********.chunk.js	2.02 kB
packages/core/admin/build/upload-translation-sk-json.********.chunk.js	2.58 kB
packages/core/admin/build/upload-translation-th-json.********.chunk.js	1.99 kB
packages/core/admin/build/upload-translation-tr-json.********.chunk.js	2.35 kB
packages/core/admin/build/upload-translation-uk-json.********.chunk.js	1.96 kB
packages/core/admin/build/upload-translation-zh-Hans-json.********.chunk.js	3.12 kB
packages/core/admin/build/upload-translation-zh-json.********.chunk.js	2.65 kB
packages/core/admin/build/upload.********.chunk.js	7.12 kB
packages/core/admin/build/users-advanced-settings-page.********.chunk.js	2.29 kB
packages/core/admin/build/users-email-settings-page.********.chunk.js	2.34 kB
packages/core/admin/build/users-permissions-translation-ar-json.********.chunk.js	1.51 kB
packages/core/admin/build/users-permissions-translation-cs-json.********.chunk.js	1.46 kB
packages/core/admin/build/users-permissions-translation-de-json.********.chunk.js	1.58 kB
packages/core/admin/build/users-permissions-translation-dk-json.********.chunk.js	1.92 kB
packages/core/admin/build/users-permissions-translation-en-json.********.chunk.js	1.81 kB
packages/core/admin/build/users-permissions-translation-es-json.********.chunk.js	2.05 kB
packages/core/admin/build/users-permissions-translation-fr-json.********.chunk.js	1.41 kB
packages/core/admin/build/users-permissions-translation-id-json.********.chunk.js	1.49 kB
packages/core/admin/build/users-permissions-translation-it-json.********.chunk.js	1.57 kB
packages/core/admin/build/users-permissions-translation-ja-json.********.chunk.js	1.53 kB
packages/core/admin/build/users-permissions-translation-ko-json.********.chunk.js	2.23 kB
packages/core/admin/build/users-permissions-translation-ms-json.********.chunk.js	1.27 kB
packages/core/admin/build/users-permissions-translation-nl-json.********.chunk.js	1.32 kB
packages/core/admin/build/users-permissions-translation-pl-json.********.chunk.js	2.11 kB
packages/core/admin/build/users-permissions-translation-pt-BR-json.********.chunk.js	1.21 kB
packages/core/admin/build/users-permissions-translation-pt-json.********.chunk.js	1.3 kB
packages/core/admin/build/users-permissions-translation-ru-json.********.chunk.js	2.75 kB
packages/core/admin/build/users-permissions-translation-sk-json.********.chunk.js	1.38 kB
packages/core/admin/build/users-permissions-translation-sv-json.********.chunk.js	2.01 kB
packages/core/admin/build/users-permissions-translation-th-json.********.chunk.js	2.01 kB
packages/core/admin/build/users-permissions-translation-tr-json.********.chunk.js	2.07 kB
packages/core/admin/build/users-permissions-translation-uk-json.********.chunk.js	1.75 kB
packages/core/admin/build/users-permissions-translation-vi-json.********.chunk.js	1.51 kB
packages/core/admin/build/users-permissions-translation-zh-Hans-json.********.chunk.js	2.19 kB
packages/core/admin/build/users-permissions-translation-zh-json.********.chunk.js	2.1 kB
packages/core/admin/build/users-providers-settings-page.********.chunk.js	3.52 kB
packages/core/admin/build/users-roles-settings-page.********.chunk.js	6.79 kB
packages/core/admin/build/vi-json.********.chunk.js	5.98 kB
packages/core/admin/build/webhook-edit-page.********.chunk.js	6.01 kB
packages/core/admin/build/webhook-list-page.********.chunk.js	3.14 kB
packages/core/admin/build/zh-Hans-json.********.chunk.js	17.1 kB
packages/core/admin/build/zh-json.********.chunk.js	15.2 kB

_{compressed-size-action}

[jhoward1994]

I can't load the admin panel with these changes, it seems to be because of the references to window.strapi in packages/core/admin/admin/src/constants.ts

Uncaught TypeError: Cannot read properties of undefined (reading 'features')

[gu-stav]

I can't load the admin panel with these changes, it seems to be because of the references to window.strapi in packages/core/admin/admin/src/constants.ts

Uncaught TypeError: Cannot read properties of undefined (reading 'features')

Good catch. I've changed the menu initialization to be lazy, to work around the fact that constants.js is imported, before the React app is already rendered. It's not beautiful but does the job for the moment. I think this needs a proper discussion about which parts are available always and after the app has been rendered.