Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(admin): convert useSettingsMenu to TS #18616

Merged
merged 2 commits into from
Nov 5, 2023
Merged

chore(admin): convert useSettingsMenu to TS #18616

merged 2 commits into from
Nov 5, 2023

Conversation

gu-stav
Copy link
Contributor

@gu-stav gu-stav commented Oct 30, 2023 •
edited by joshuaellis
Loading

What does it do?

  • convert useSettingsMenu to TS
  • better type useEnterprise for more powerful inference

Why is it needed?

  • TS TS TS

@joshuaellis joshuaellis force-pushed the chore/useSettingsMenu-ts-3 branch 2 times, most recently from 3bd370d to 8d243d0 Compare November 5, 2023 10:52
@joshuaellis joshuaellis marked this pull request as ready for review November 5, 2023 10:52
@joshuaellis joshuaellis added source: core:admin Source is core/admin package pr: chore This PR contains chore tasks (cleanups, configs, tooling...) labels Nov 5, 2023
@joshuaellis joshuaellis self-requested a review November 5, 2023 10:52
@joshuaellis joshuaellis modified the milestones: 4.15.2, 4.15.3 Nov 5, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2023 •
edited
Loading

Size Change: -18 B (0%)

Total Size: 628 kB

Filename Size Change
examples/getstarted/build/main.********.js 621 kB -18 B (0%)
ℹ️ View Unchanged
Filename Size Change
examples/getstarted/build/bb4d0d527bdfb161bc5a.svg 2.33 kB 0 B
examples/getstarted/build/index.html 611 B +1 B (0%)
examples/getstarted/build/runtime~main.********.js 4.25 kB -1 B (0%)

compressed-size-action

@joshuaellis joshuaellis merged commit 477ea8e into main Nov 5, 2023
115 of 120 checks passed
@joshuaellis joshuaellis deleted the chore/useSettingsMenu-ts-3 branch November 5, 2023 13:45
@alexandrebodin alexandrebodin modified the milestones: 4.15.3, 4.15.2 Nov 8, 2023
@joshuaellis joshuaellis modified the milestones: 4.15.2, 4.15.5 Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuaellis joshuaellis joshuaellis approved these changes

Assignees
No one assigned
Labels
pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: core:admin Source is core/admin package
Projects
None yet
Milestone
4.15.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gu-stav @joshuaellis @alexandrebodin