Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: pack-up all admin packages #18622

Merged
merged 3 commits into from
Oct 31, 2023
Merged

chore: pack-up all admin packages #18622

merged 3 commits into from
Oct 31, 2023

Conversation

joshuaellis
Copy link
Member

@joshuaellis joshuaellis commented Oct 31, 2023 •
edited
Loading

What does it do?

  • packs up all the packages with FE code
  • sorts out some eslint config stuff so it's cleaner and easier (and still works)
  • removes implictDeps arguments in package.json

Why is it needed?

  • vite and other builders really don't like JSX code in JS files so it's easier to transpile our packages now before working on bundler stuff
  • implicitDeps was hard to keep track of and not that helpful, pack-up understands externals & can manage the circular dependency stuff – I also think it's really important we keep that warning as a reminder we need to actually solve it.

@joshuaellis joshuaellis added source: tooling Source is GitHub tooling/tests/ect pr: chore This PR contains chore tasks (cleanups, configs, tooling...) labels Oct 31, 2023
@joshuaellis joshuaellis added this to the 4.15.2 milestone Oct 31, 2023
@joshuaellis joshuaellis self-assigned this Oct 31, 2023
Marc-Roig
Marc-Roig previously approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@Marc-Roig Marc-Roig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets go 🚀

@joshuaellis joshuaellis force-pushed the chore/pack-up-all-admin-packages branch from fbab2b9 to d32fa89 Compare October 31, 2023 09:36
@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2023 •
edited
Loading

Size Change: -2.2 kB (0%)

Total Size: 629 kB

Filename Size Change
examples/getstarted/build/main.********.js 621 kB -2.19 kB (0%)
examples/getstarted/build/runtime~main.********.js 4.26 kB -16 B (0%)
ℹ️ View Unchanged
Filename Size Change
examples/getstarted/build/bb4d0d527bdfb161bc5a.svg 2.33 kB 0 B
examples/getstarted/build/index.html 607 B -1 B (0%)

compressed-size-action

@joshuaellis joshuaellis force-pushed the chore/pack-up-all-admin-packages branch from b78c5bf to ecc6268 Compare October 31, 2023 12:26
@joshuaellis joshuaellis force-pushed the chore/pack-up-all-admin-packages branch from ecc6268 to 874bfbe Compare October 31, 2023 12:33
Marc-Roig
Marc-Roig reviewed Oct 31, 2023
View reviewed changes
packages/core/admin/package.json
@@ -170,7 +169,9 @@
},
"devDependencies": {
"@strapi/admin-test-utils": "4.15.0",
"@strapi/data-transfer": "4.15.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isnt data transfer used as a regular dependency?

strapi/packages/core/admin/server/controllers/transfer/runner.js

Line 3 in d6895f2

const { createPushController, createPullController } =

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is yeah, but it's listed as a peer dependency, so when admin is installed, it shouldn't download it's own version of DTS hence why it's in devDeps

@joshuaellis joshuaellis merged commit 4ef442c into main Oct 31, 2023
138 checks passed
@joshuaellis joshuaellis deleted the chore/pack-up-all-admin-packages branch October 31, 2023 15:38
@alexandrebodin alexandrebodin modified the milestones: 4.15.2, 4.15.3 Nov 3, 2023
joshuaellis added a commit that referenced this pull request Nov 8, 2023
@joshuaellis
chore: pack-up all admin packages (#18622)
cb1e4e9 
* chore: pack-up all admin packages

* chore: remove implicit deps

* chore: fix test
@alexandrebodin alexandrebodin modified the milestones: 4.15.3, 4.15.2 Nov 8, 2023
@joshuaellis joshuaellis modified the milestones: 4.15.2, 4.15.5 Nov 13, 2023
UnKnoWn-Consortium added a commit to UnKnoWn-Consortium/strapi-plugin-responsive-image that referenced this pull request Nov 19, 2023
@UnKnoWn-Consortium
fix: import @strapi/upload components with the newly defined export…
897f8e4 
…s since v4.15.1 (ref: strapi/strapi#18622)

chore(package.json): updated engines to match ``@strapi/upload`
chore(version): bumped version
@UnKnoWn-Consortium UnKnoWn-Consortium mentioned this pull request Nov 19, 2023
Merged
@renovate renovate bot mentioned this pull request Mar 20, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marc-Roig Marc-Roig Marc-Roig approved these changes

@jhoward1994 jhoward1994 Awaiting requested review from jhoward1994

Assignees

@joshuaellis joshuaellis

Labels
pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: tooling Source is GitHub tooling/tests/ect
Projects
None yet
Milestone
4.15.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joshuaellis @Marc-Roig @alexandrebodin