Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(admin): fix exports & settings links in CE #18624

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Conversation

joshuaellis
Copy link
Member

What does it do?

  • adds index.js & index.d.ts to the files array of @strapi/admin
  • adds the additionalDeps to quick start projects
  • ensures we always unwrap the CE settings links for settings otherwise they're undefined

Why is it needed?

  • admin was not shipping with a file it required

Related issue(s)/PR(s)

@joshuaellis joshuaellis added source: core:admin Source is core/admin package pr: fix This PR is fixing a bug labels Oct 31, 2023
@joshuaellis joshuaellis added this to the 4.15.2 milestone Oct 31, 2023
@joshuaellis joshuaellis self-assigned this Oct 31, 2023
@github-actions
Copy link
Contributor

Size Change: +1 B (0%)

Total Size: 631 kB

ℹ️ View Unchanged
Filename Size Change
examples/getstarted/build/bb4d0d527bdfb161bc5a.svg 2.33 kB 0 B
examples/getstarted/build/index.html 609 B +1 B (0%)
examples/getstarted/build/main.********.js 624 kB 0 B
examples/getstarted/build/runtime~main.********.js 4.28 kB 0 B

compressed-size-action

@joshuaellis joshuaellis merged commit c563f77 into main Oct 31, 2023
144 checks passed
@joshuaellis joshuaellis deleted the chore/fix-admin branch October 31, 2023 15:36
@alexandrebodin alexandrebodin modified the milestones: 4.15.2, 4.15.3 Nov 3, 2023
joshuaellis added a commit that referenced this pull request Nov 8, 2023
* chore(admin): add index files to files list

* chore: incl. additional deps with quickstart projects

* chore: fix issue with menu links being undefined.
@alexandrebodin alexandrebodin modified the milestones: 4.15.3, 4.15.2 Nov 8, 2023
@joshuaellis joshuaellis modified the milestones: 4.15.2, 4.15.5 Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix This PR is fixing a bug source: core:admin Source is core/admin package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants