Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(admin): auth pages to TS #18635

Merged
merged 6 commits into from
Nov 2, 2023
Merged

refactor(admin): auth pages to TS #18635

merged 6 commits into from
Nov 2, 2023

Conversation

joshuaellis
Copy link
Member

@joshuaellis joshuaellis commented Nov 1, 2023 •
edited
Loading

What does it do?

  • Converts Auth to TS
  • Refactors because the current setup was not going to work in a TS environment and was extremely hard to understand

Why is it needed?

  • TS TS TS

How to test it?

  • E2E tests helped a lot (shout to @jhoward1994)
  • Added more automation tests

@joshuaellis joshuaellis added source: core:admin Source is core/admin package pr: chore This PR contains chore tasks (cleanups, configs, tooling...) labels Nov 1, 2023
@joshuaellis joshuaellis added this to the 4.15.2 milestone Nov 1, 2023
@joshuaellis joshuaellis self-assigned this Nov 1, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2023 •
edited
Loading

Size Change: -803 B (0%)

Total Size: 628 kB

Filename Size Change
examples/getstarted/build/main.********.js 621 kB -794 B (0%)
ℹ️ View Unchanged
Filename Size Change
examples/getstarted/build/bb4d0d527bdfb161bc5a.svg 2.33 kB 0 B
examples/getstarted/build/index.html 608 B -2 B (0%)
examples/getstarted/build/runtime~main.********.js 4.25 kB -7 B (0%)

compressed-size-action

@joshuaellis
Copy link
Member Author

thanks for that @jhoward1994 – made those changes 😎

jhoward1994
jhoward1994 approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@jhoward1994 jhoward1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, its all working for me 👍🏻

@joshuaellis joshuaellis merged commit d482633 into main Nov 2, 2023
139 of 140 checks passed
@joshuaellis joshuaellis deleted the chore/refactor-auth branch November 2, 2023 14:31
@alexandrebodin alexandrebodin modified the milestones: 4.15.2, 4.15.3 Nov 3, 2023
@joshuaellis joshuaellis modified the milestones: 4.15.2, 4.15.5 Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhoward1994 jhoward1994 jhoward1994 approved these changes

@gu-stav gu-stav Awaiting requested review from gu-stav

@Marc-Roig Marc-Roig Awaiting requested review from Marc-Roig

Assignees

@joshuaellis joshuaellis

Labels
pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: core:admin Source is core/admin package
Projects
None yet
Milestone
4.15.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joshuaellis @jhoward1994 @alexandrebodin