Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core/admin): missing env utilities #18657

Merged
merged 1 commit into from
Nov 3, 2023
Merged

fix(core/admin): missing env utilities #18657

merged 1 commit into from
Nov 3, 2023

Conversation

alexandrebodin
Copy link
Member

@alexandrebodin alexandrebodin commented Nov 3, 2023 •
edited by joshuaellis

What does it do?

  • passes env from @strapi/utils to plugin configuration functions

Why is it needed?

  • preserves existing functionality

Related issue(s)/PR(s)

@alexandrebodin alexandrebodin added source: core:admin Source is core/admin package pr: fix This PR is fixing a bug labels Nov 3, 2023
@alexandrebodin alexandrebodin self-assigned this Nov 3, 2023
@joshuaellis joshuaellis merged commit f5b09a8 into main Nov 3, 2023
30 of 31 checks passed
@joshuaellis joshuaellis deleted the fix/plugin-load-env branch November 3, 2023 08:52
@joshuaellis joshuaellis added this to the 4.15.2 milestone Nov 3, 2023
alexandrebodin added a commit that referenced this pull request Nov 3, 2023
@alexandrebodin
fix(admin): missing env utilities (#18657)
5f65fd6
@alexandrebodin alexandrebodin modified the milestones: 4.15.2, 4.15.3 Nov 3, 2023
@joshuaellis joshuaellis mentioned this pull request Nov 3, 2023
Closed
@derrickmehaffy derrickmehaffy mentioned this pull request Nov 12, 2023
Closed
@joshuaellis joshuaellis modified the milestones: 4.15.2, 4.15.5 Nov 13, 2023
This was referenced Apr 17, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuaellis joshuaellis joshuaellis approved these changes

Assignees

@alexandrebodin alexandrebodin

Labels
pr: fix This PR is fixing a bug source: core:admin Source is core/admin package
Projects
None yet
Milestone
4.15.2
Development

Successfully merging this pull request may close these issues.

loadUserPluginsFile tries to evaluate function without required parameter
2 participants
@alexandrebodin @joshuaellis