Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin): build pipeline & deps #18658

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Conversation

joshuaellis
Copy link
Member

@joshuaellis joshuaellis commented Nov 3, 2023

What does it do?

  • adds esbuild as a dep to the admin package
  • sets peerDeps to match the design-system which is lower than what we were targeting incl. on templates so all packages are aligned
  • re-exports admin from the strapi package and no longer tries to include the core plugins on a user app level

Why is it needed?

  • upgrading projects couldn't resolve esbuild
  • peer dep issues in npm projects
  • it's NPM specific but the admin package is not at the same level in the node_modules so you can't import it. Because a user has @strapi/strapi declared, we might as well use that and re-export it. We can also import the core plugins there meaning we're another step closer to PNPM working.

How to test it?

  • install a project at 4.15.0
  • upgrade to experimental manually
  • experimental build –> 0.0.0-experimental.1cec6226fe6c8ca4b8404f1ebac8076d5ee5b336
  • should build sucessfully

Related issue(s)/PR(s)

@joshuaellis joshuaellis added source: dependencies Source is dependency problem pr: fix This PR is fixing a bug labels Nov 3, 2023
@joshuaellis joshuaellis added this to the 4.15.2 milestone Nov 3, 2023
@joshuaellis joshuaellis self-assigned this Nov 3, 2023
Copy link
Contributor

github-actions bot commented Nov 3, 2023

Size Change: -7 B (0%)

Total Size: 630 kB

Filename Size Change
examples/getstarted/build/runtime~main.********.js 4.28 kB -11 B (0%)
ℹ️ View Unchanged
Filename Size Change
examples/getstarted/build/bb4d0d527bdfb161bc5a.svg 2.33 kB 0 B
examples/getstarted/build/index.html 609 B 0 B
examples/getstarted/build/main.********.js 623 kB +4 B (0%)

compressed-size-action

@joshuaellis joshuaellis changed the title chore(admin): add index files to files list chore(admin): fix build pipeline Nov 3, 2023
@joshuaellis joshuaellis changed the title chore(admin): fix build pipeline fix(admin): build pipeline & deps Nov 3, 2023
@joshuaellis
Copy link
Member Author

I actually think this fixes #15992

@alexandrebodin alexandrebodin merged commit 0e69461 into releases/4.15.3 Nov 3, 2023
136 of 137 checks passed
@alexandrebodin alexandrebodin deleted the chore/fix-deps branch November 3, 2023 14:56
@joshuaellis joshuaellis modified the milestones: 4.15.2, 4.15.5 Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix This PR is fixing a bug source: dependencies Source is dependency problem
Projects
None yet
2 participants