Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(admin): close webpack watch on reload #18667

Merged
merged 1 commit into from
Nov 3, 2023
Merged

fix(admin): close webpack watch on reload #18667

merged 1 commit into from
Nov 3, 2023

Conversation

alexandrebodin
Copy link
Member

@alexandrebodin alexandrebodin commented Nov 3, 2023 •
edited by joshuaellis
Loading

What does it do?

  • Closes webpack watcher on reloads

Why is it needed?

  • Avoid having background rebuild slowing down the app because the compiler / dev-middleware was not being terminated by the parent process

Related issue(s)/PR(s)

  • resolves CONTENT-2036

@alexandrebodin alexandrebodin added source: core:admin Source is core/admin package pr: fix This PR is fixing a bug labels Nov 3, 2023
@alexandrebodin alexandrebodin added this to the 4.15.2 milestone Nov 3, 2023
@alexandrebodin alexandrebodin merged commit 805908b into releases/4.15.2 Nov 3, 2023
24 checks passed
@alexandrebodin alexandrebodin deleted the fix/admin-watcher branch November 3, 2023 15:28
@joshuaellis joshuaellis modified the milestones: 4.15.2, 4.15.5 Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuaellis joshuaellis joshuaellis approved these changes

Assignees
No one assigned
Labels
pr: fix This PR is fixing a bug source: core:admin Source is core/admin package
Projects
None yet
Milestone
4.15.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexandrebodin @joshuaellis