Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: import Document directly & add ignorePrompts CLI flag #18668

Merged
merged 2 commits into from
Nov 3, 2023
Merged

fix: import Document directly & add ignorePrompts CLI flag #18668

merged 2 commits into from
Nov 3, 2023

Conversation

joshuaellis
Copy link
Member

What does it do?

  • Adds ignorePrompts flag to CLI for local / CI uses where you want to ignore the fact we want you to install the deps
  • Fixes issue of dynamically importing DefaultDocument when styled-components is not a root node_module in yarn only (it was fine in npm)

Why is it needed?

  • users who build strapi in CI using NODE_ENV=development cannot get past the message
  • you shouldn't need to install styled-components

How to test it?

  • upgrade from 4.15.0 to 0.0.0-experimental.1a3c6a749103fb5f9416579d47e7ed2239fed710
  • run build
  • say no to install prompt
  • SUCCESS!

Related issue(s)/PR(s)

@joshuaellis joshuaellis added source: core:admin Source is core/admin package pr: fix This PR is fixing a bug labels Nov 3, 2023
@joshuaellis joshuaellis added this to the 4.15.2 milestone Nov 3, 2023
@joshuaellis joshuaellis self-assigned this Nov 3, 2023
@joshuaellis joshuaellis linked an issue Nov 3, 2023 that may be closed by this pull request
4.15.1 npm run build requires console interaction on every build #18666
Closed
@joshuaellis joshuaellis changed the title chore: import directly Document to avoid looking for styled-components fix: import directly Document directly & add ignorePrompts CLI flag Nov 3, 2023
@alexandrebodin alexandrebodin changed the title fix: import directly Document directly & add ignorePrompts CLI flag fix: import Document directly & add ignorePrompts CLI flag Nov 3, 2023
@alexandrebodin alexandrebodin merged commit e741a4a into releases/4.15.2 Nov 3, 2023
24 checks passed
@alexandrebodin alexandrebodin deleted the fix/yarn-styled-components-issue branch November 3, 2023 16:06
@joshuaellis joshuaellis modified the milestones: 4.15.2, 4.15.5 Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandrebodin alexandrebodin alexandrebodin approved these changes

Assignees

@joshuaellis joshuaellis

Labels
pr: fix This PR is fixing a bug source: core:admin Source is core/admin package
Projects
None yet
Milestone
4.15.2
Development

Successfully merging this pull request may close these issues.

4.15.1 npm run build requires console interaction on every build
2 participants
@joshuaellis @alexandrebodin