Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(admin): add watch-admin flag #18688

Merged
merged 1 commit into from
Nov 7, 2023
Merged

refactor(admin): add watch-admin flag #18688

merged 1 commit into from
Nov 7, 2023

Conversation

joshuaellis
Copy link
Member

What does it do?

  • adds watch-admin flag to trigger the watching middleware attaching process

Why is it needed?

  • only lower powered machines the current reload set up is very slow due to webpack re-compiling, this is intended to be a patch until we solve the issue.

@joshuaellis joshuaellis added source: core:admin Source is core/admin package pr: enhancement This PR adds or updates some part of the codebase or features flag: documentation This PR requires a documentation update labels Nov 6, 2023
@joshuaellis joshuaellis added this to the 4.15.2 milestone Nov 6, 2023
@joshuaellis joshuaellis self-assigned this Nov 6, 2023
@joshuaellis joshuaellis mentioned this pull request Nov 7, 2023
Merged
@joshuaellis joshuaellis removed the flag: documentation This PR requires a documentation update label Nov 7, 2023
@joshuaellis
Copy link
Member Author

Updated the documentation in the PR above.

@alexandrebodin alexandrebodin merged commit ca1ec5a into releases/4.15.2 Nov 7, 2023
25 checks passed
@alexandrebodin alexandrebodin deleted the refactor/add-watch-admin-flag branch November 7, 2023 10:37
@joshuaellis joshuaellis modified the milestones: 4.15.2, 4.15.5 Nov 13, 2023
@renovate renovate bot mentioned this pull request Apr 10, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandrebodin alexandrebodin alexandrebodin approved these changes

Assignees

@joshuaellis joshuaellis

Labels
pr: enhancement This PR adds or updates some part of the codebase or features source: core:admin Source is core/admin package
Projects
None yet
Milestone
4.15.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joshuaellis @alexandrebodin