fix(admin): only check if app.js file exists before trying to use it #18780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandrebodin
added
source: core:admin
|
@joshuaellis I'm wondering why we even bother using esbuild to load that file ? we just need it's path to generate the |
I don't think we need to in retrospective, although in the future we might want to run validations against it but we can do that another time. I think using |
joshuaellis
reviewed
Nov 14, 2023
alexandrebodin
force-pushed
the
fix/load-app-custom
branch
from
5378a56
to
c9ec5ee
Compare
joshuaellis
approved these changes
Nov 14, 2023
joshuaellis
changed the title
yuan1238y
reviewed
Dec 25, 2023
|
|
||
| if (configFile) { | ||
| return { path: filePath, config: configFile }; | ||
| if (fs.existsSync(filePath)) { |
There was a problem hiding this comment.
Why use existsSync in async function ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Upgrade the laodFile util to support required feature.
Why is it needed?
Fix an issue with custom app code
How to test it?
create a src/admin/app.(ts|tsx|js|jsx) file with jsx code in it
Related issue(s)/PR(s)
Let us know if this is related to any issue/pull request