fix(admin): windows files paths do not make for module paths #18797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuaellis
added
source: core:admin
|
@alexandrebodin this is what i was thinking, we do it in three places all in different areas, i think it makes more sense to have some utility functions to handle the behaviour & try to solve this all in the build context area |
|
@joshuaellis can you when you are done working on this do an experimental so I can check if it fixes the issue? |
This comment was marked as outdated.
This comment was marked as outdated.
gu-stav
reviewed
Nov 15, 2023
|
Checked it on windows and if fixes the issue |
joshuaellis
force-pushed
the
chore/fix-windows-module-paths
branch
from
b18de92
to
e6fa2c2
Compare
This comment was marked as outdated.
This comment was marked as outdated.
joshuaellis
force-pushed
the
chore/fix-windows-module-paths
branch
from
e6fa2c2
to
70cc857
Compare
|
experimental – 0.0.0-experimental.70cc85706c9f5d5fb91aa258438a10cbc0a2acaf |
alexandrebodin
approved these changes
Nov 15, 2023
There was a problem hiding this comment.
LGTM on mac let's wait for @Boegie19 to test on windows before merging
|
Tested it on windows and issue is fixed on 0.0.0-experimental.70cc85706c9f5d5fb91aa258438a10cbc0a2acaf aswell |
|
Thanks all 🌞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Why is it needed?
app.jsfile was not being imported correctlyRelated issue(s)/PR(s)